[infra] Support syslog rate limit configuration #12490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junchao-Mellanox
requested review from
qiluo-msft,
xumia and
lguohan
as code owners
keboliu
approved these changes
Nov 7, 2022
mkeda
approved these changes
Nov 10, 2022
7 tasks
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please fix the build errors. |
|
It has a build dependency on #12489 , once that PR is merged, I will rebase this one. |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saiarcot895
approved these changes
Dec 13, 2022
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @saiarcot895, I fixed a typo in containercfgd.py (introduced by previous comment fix), would you please check it? |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saiarcot895
approved these changes
Dec 19, 2022
liat-grozovik
approved these changes
Dec 20, 2022
|
@Junchao-Mellanox PR conflicts with 202211 branch |
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-buildimage
that referenced
this pull request
Jan 29, 2023
- Why I did it Support syslog rate limit configuration feature - How I did it Remove unused rsyslog.conf from containers Modify docker startup script to generate rsyslog.conf from template files Add metadata/init data for syslog rate limit configuration - How to verify it Manual test New sonic-mgmt regression cases Conflicts: platform/vs/docker-sonic-vs/Dockerfile.j2
7 tasks
|
Created backport PR #13535 |
liat-grozovik
pushed a commit
that referenced
this pull request
Jan 30, 2023
Backport of #12490 into 202211 - Why I did it Support syslog rate limit configuration feature - How I did it Remove unused rsyslog.conf from containers Modify docker startup script to generate rsyslog.conf from template files Add metadata/init data for syslog rate limit configuration - How to verify it Manual test New sonic-mgmt regression cases
StormLiangMS
added
Included in 202211 Branch
and removed
Cherry Pick Conflict_202211
labels
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-buildimage
that referenced
this pull request
Dec 5, 2023
)" This reverts commit 2126def.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HLD: sonic-net/SONiC#1049
Depends on #12489 (Build dependency)
Why I did it
Support syslog rate limit configuration feature
How I did it
How to verify it
Manual test
New sonic-mgmt regression cases
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)