Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ipmitool to SONIC rootfs #1448

Closed
wants to merge 2 commits into from
Closed

Add ipmitool to SONIC rootfs #1448

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d36e8be
Add ipmitool to SONIC rootfs
jostar-yang Mar 2, 2018
8a27807
Merge branch 'master' into 20180302_a0001
jostar-yang Mar 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build_debian.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,8 @@ sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get -y in
gdisk \
sysfsutils \
grub2-common \
ethtool
ethtool \
ipmitool
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this into pmon docker? will it work?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jleveque

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ipmitool is common utility. It should put to "/usr/bin" for user application can access BMC.
If there is any concern on SONIC project, please tell me how to add ipmitool cmd to pmon docker.
I need to study and test on as7716-32XB BMC project. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We study pmon docker and ipmitool use. We think ipmitool is like i2c-tool that are common utility tool. Ipmitool should put to /usr/bin or usr/sbin in SONiC rootfs, not put to any docker container. For BMC project, user only can access i2c from ipmitool. For non-MBC project, user can access i2c from i2c-tool.


sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get -y download \
grub-pc-bin
Expand Down