Updating sonic motd with official logo #1487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one should satisfy most of the initial concerns: no more than 80-cols wide, and no more than 80-lines long. Let me know if any suggestion.
jleveque
suggested changes
Mar 14, 2018
| \___ \| | | | \| | | | | ||
| ___) | |_| | |\ | | |___ | ||
| |____/ \___/|_| \_|_|\____| | ||
|
|
There was a problem hiding this comment.
I like it, but I feel it's too big. Also, I think all text underneath should be centered on the logo. Also, do we need to keep the "You are on" line?
Here's more of what I'm thinking:
,,,,,
,,,,,,,,,,,,.
/***,,,,,,,,
/(///***,,,,.
(#(((///***, ,
**##((///. ##
****//* *#####,
****///// %%%#### (((######,
.***/////(((#%%%%%####(((((((######,
.**////(((((##%%#(/((((((((######,
.&%///(((((###(//((((((((#/#####,
%&&&&%%%#((((###(//(((((, /#####,
***#&%%%# (###(///( /#####,
****/// *(, *(#####,
****/////( ((((######
***/////((((/ ,(((((((#####
.////(((((### //(((((((((#*
/(((((###(//(((((((
*((###(//(((*
.##(//.
____ ___ _ _ _ ____
/ ___| / _ \| \ | (_)/ ___|
\___ \| | | | \| | | |
___) | |_| | |\ | | |___
|____/ \___/|_| \_|_|\____|
-- Software for Open Networking in the Cloud --
Unauthorized access and/or use are prohibited.
All access and/or use are subject to monitoring.
Help: http://azure.github.io/SONiC/
There was a problem hiding this comment.
I think this logo is trying to match the gradual change of the color
Actually I have a black/white version of the logo
I think that might be more suitable in the motd
There was a problem hiding this comment.
also feel it is a little big
There was a problem hiding this comment.
I feel should be with 80-col width and 40~50 rows.
There was a problem hiding this comment.
@lguohan, my current proposal is already meeting your size criteria: 66 columns and 38 rows. Please keep in mind that in reality t looks considerably smaller than what it appears in this github ascii file. Have no issues making it smaller if you all agree, but keep in mind that the image won't look that neat anymore. Please let me know.
jleveque
reviewed
Feb 7, 2019
There was a problem hiding this comment.
This PR has been open for almost a full year. I think we're long overdue for freshening up the MOTD! My vote at this point is simply to remove the first three lines (the "You are on" line and two blank lines following it), bringing the entire MOTD (logo and text) to 40 rows total and center the text at the bottom. Here's my suggestion, line for line:
,,,,
.,,,,,,,,,,.
*,,,,,,,,,,,,,,,,,.
*****,,,,,,,,,,,,,,.
///*****,,,,,,,,,,,.
*((////*****,,,,,,,,
,#(((((////*****,,,,
(###(((((////*****. #.
**###(((((/////* ##.
*****((((((//, /####(
*******//(/ ,#########
*******/////. #%%#%%, ((###########
,******///////// *%%%%%%%#####( ,(((((###########
******////////((((%%%%%%%%%%%#######(((((((((###########
******///////(((((((#%%%%%%%####((((((((((((###########
,*////////((((((((####%##(//(((((((((((((###########
/%//////((((((((#####////(((((((((((((############
#&&&&&%%///((((((((#####////((((((((((((, ##########
.#&&&&&&&%%%%%#(((((((#####////((((((((/ ##########
.***&&&&&&%%%%%%* /(((#####////(((((. ##########
*******%&&%%( .#####/////* ##########
********//# .##//* /##########
*******/////// .(((##########(
.******////////((. /((((((#########
*****////////(((((/ .((((((((((########(
****///////((((((((( ,(((((((((((((######,
,///////((((((((####/.////((((((((((((((#(
*//(((((((((#####////(((((((((((((.
.((((((((#####////(((((((((*
/((((#####////((((((
*(#####////((/
###///,
____ ___ _ _ _ ____
/ ___| / _ \| \ | (_)/ ___|
\___ \| | | | \| | | |
___) | |_| | |\ | | |___
|____/ \___/|_| \_|_|\____|
-- Software for Open Networking in the Cloud --
Unauthorized access and/or use are prohibited.
All access and/or use are subject to monitoring.
Help: http://azure.github.io/SONiC/
lguohan
added a commit
to lguohan/sonic-buildimage
that referenced
this pull request
Nov 1, 2020
swss: * d7643f2 2020-11-01 | [tlm_teamd]: Make the destionation for std::transform() to use std::back_inserter() for allocating new space for the copied objects (sonic-net#1490) (HEAD, origin/master, origin/HEAD) [pavel-shirshov] * 7fa7cd6 2020-10-31 | [vstest]: stablize fgnhg test (sonic-net#1491) [lguohan] * 9b0696e 2020-10-29 | Create vnet tunnel map only if it doesn't exist (sonic-net#1482) [Prince Sunny] * 0481e99 2020-10-29 | [acl] Update CRM to include LAG bindings for ACL tables (sonic-net#1487) [Danny Allen] sairedis * 5df11f5 2020-11-01 | [syncd] Lower bulk missing api message level from error to info (sonic-net#687) (HEAD, origin/master, origin/HEAD) [Kamil Cudnik] * dc73a1d 2020-10-30 | [saiplayer] Fix log messages (sonic-net#686) [Kamil Cudnik] Signed-off-by: Guohan Lu <[email protected]>
3 tasks
lguohan
added a commit
that referenced
this pull request
Nov 2, 2020
swss: * d7643f2 2020-11-01 | [tlm_teamd]: Make the destionation for std::transform() to use std::back_inserter() for allocating new space for the copied objects (#1490) (HEAD, origin/master, origin/HEAD) [pavel-shirshov] * 7fa7cd6 2020-10-31 | [vstest]: stablize fgnhg test (#1491) [lguohan] * 9b0696e 2020-10-29 | Create vnet tunnel map only if it doesn't exist (#1482) [Prince Sunny] * 0481e99 2020-10-29 | [acl] Update CRM to include LAG bindings for ACL tables (#1487) [Danny Allen] sairedis * 5df11f5 2020-11-01 | [syncd] Lower bulk missing api message level from error to info (#687) (HEAD, origin/master, origin/HEAD) [Kamil Cudnik] * dc73a1d 2020-10-30 | [saiplayer] Fix log messages (#686) [Kamil Cudnik] Signed-off-by: Guohan Lu <[email protected]>
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
swss: * d7643f2 2020-11-01 | [tlm_teamd]: Make the destionation for std::transform() to use std::back_inserter() for allocating new space for the copied objects (sonic-net#1490) (HEAD, origin/master, origin/HEAD) [pavel-shirshov] * 7fa7cd6 2020-10-31 | [vstest]: stablize fgnhg test (sonic-net#1491) [lguohan] * 9b0696e 2020-10-29 | Create vnet tunnel map only if it doesn't exist (sonic-net#1482) [Prince Sunny] * 0481e99 2020-10-29 | [acl] Update CRM to include LAG bindings for ACL tables (sonic-net#1487) [Danny Allen] sairedis * 5df11f5 2020-11-01 | [syncd] Lower bulk missing api message level from error to info (sonic-net#687) (HEAD, origin/master, origin/HEAD) [Kamil Cudnik] * dc73a1d 2020-10-30 | [saiplayer] Fix log messages (sonic-net#686) [Kamil Cudnik] Signed-off-by: Guohan Lu <[email protected]>
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Apr 8, 2021
* d58ba82 2021-04-05 | Fix fast-reboot fdb filtering for IPv6 addresses (sonic-net#1548) (github/201811) [Vaibhav Hemant Dixit] * cc7ad9e 2021-03-24 | Fast reboot: check if the files are present before accessing (sonic-net#1526) [Vaibhav Hemant Dixit] * 410323a 2021-03-24 | [201811] Add missing variable DEVPATH to fast-reboot script (sonic-net#1525) [Vaibhav Hemant Dixit] * eb5023a 2021-03-21 | [201811] soft-reboot (sonic-net#1487) [Sujin Kang] * 3f10540 2020-12-08 | [fast-reboot] Fix fast-reboot when NDP entries are present (sonic-net#1295) (HEAD -> 201811) [shlomibitton] Signed-off-by: Ying Xie <[email protected]>
yxieca
added a commit
that referenced
this pull request
Apr 9, 2021
* d58ba82 2021-04-05 | Fix fast-reboot fdb filtering for IPv6 addresses (#1548) (github/201811) [Vaibhav Hemant Dixit] * cc7ad9e 2021-03-24 | Fast reboot: check if the files are present before accessing (#1526) [Vaibhav Hemant Dixit] * 410323a 2021-03-24 | [201811] Add missing variable DEVPATH to fast-reboot script (#1525) [Vaibhav Hemant Dixit] * eb5023a 2021-03-21 | [201811] soft-reboot (#1487) [Sujin Kang] * 3f10540 2020-12-08 | [fast-reboot] Fix fast-reboot when NDP entries are present (#1295) (HEAD -> 201811) [shlomibitton] Signed-off-by: Ying Xie <[email protected]>
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
Signed-off-by: Danny Allen <[email protected]>
github-actions bot
pushed a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jan 2, 2025
…tically (sonic-net#21287) #### Why I did it src/sonic-sairedis ``` * 1684aecf - (HEAD -> master, origin/master, origin/HEAD) [syncd] Enable bulk api for next hop objects (sonic-net#1487) (2 days ago) [Nikola Dancejic] ``` #### How I did it #### How to verify it #### Description for the changelog
github-actions bot
pushed a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jan 2, 2025
…tically (sonic-net#21287) #### Why I did it src/sonic-sairedis ``` * 1684aecf - (HEAD -> master, origin/master, origin/HEAD) [syncd] Enable bulk api for next hop objects (sonic-net#1487) (2 days ago) [Nikola Dancejic] ``` #### How I did it #### How to verify it #### Description for the changelog
github-actions bot
pushed a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jan 2, 2025
…tically (sonic-net#21287) #### Why I did it src/sonic-sairedis ``` * 1684aecf - (HEAD -> master, origin/master, origin/HEAD) [syncd] Enable bulk api for next hop objects (sonic-net#1487) (2 days ago) [Nikola Dancejic] ``` #### How I did it #### How to verify it #### Description for the changelog
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
…tically (sonic-net#21287) #### Why I did it src/sonic-sairedis ``` * 1684aecf - (HEAD -> master, origin/master, origin/HEAD) [syncd] Enable bulk api for next hop objects (sonic-net#1487) (2 days ago) [Nikola Dancejic] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one should satisfy most of the initial concerns: no more than 80-cols wide, and no more than 80-lines long. Let me know if any suggestion.