[202205] Fix issue: set has_timer attribute to true for platform monitor service (#15816) #15624
Conversation
| @@ -36,7 +36,6 @@ | |||
| ("database", "always_enabled", false, "always_enabled"), | |||
| ("lldp", "enabled", true, "enabled"), | |||
| ("pmon", "enabled", true, "enabled"), | |||
| ("pmon", "enabled", false, "enabled"), | |||
There was a problem hiding this comment.
@Junchao-Mellanox why NOT remove ("pmon", "enabled", true, "enabled")? and keep it same as previous
"pmon": {
"state": "enabled",
"has_timer": false,
"has_global_scope": true,
"has_per_asic_scope": "False",
"auto_restart": "enabled",
"high_mem_alert": "disabled"
},
There was a problem hiding this comment.
We will use a timer to start pmon in fastreboot/warmreboot flow. By doing this, we would save fast reboot traffic down time.
|
@Junchao-Mellanox please raise a PR for master and let it be cherry-picked to 202205. @yxieca FYI |
Hi @prgeor , this is the PR for master, and it cannot be cherry-picked to 202205 cleanly, so I added this PR for 202205. |
@Junchao-Mellanox can you mention the master branch PR in this PR for record? |
|
Master PR: #15816 |
|
Hi @yxieca , since we already have #15334 in master/202211/202305 which makes PMON delayed by an event driven mechanism , i have closed the master PR. I created a new master PR only remove the redundant line. I suppose we still need current PR in 202205 because we are not going to cherry-pick 15334 to 202205. |
liat-grozovik
changed the title
|
@yxieca is it ok to be merged now? |
|
Hi @yxieca , could you please help merge this? |
Backport PR #15816
Why I did it
There is a redundant line in init_cfg.json.j2. It would cause pmon service always has "has_timer=False". However, we know that PMON has a timer now. So, I try to fix it here.
Work item tracking
How I did it
Remove the redundant line
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)