[TACACS] Ignore TACACS accounting trace log when debug disabled. #16482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
re-trigger build by close and re-open |
qiluo-msft
approved these changes
Sep 26, 2023
|
Close by mistake, re-open |
9 tasks
qiluo-msft
pushed a commit
that referenced
this pull request
Mar 21, 2024
Fix TACACS local accounting disabled when debug flag disabled. #### Why I did it TACACS local accounting use trace() method to output local accounting log, following PR disable trace log when debug flag disabled, #16482 Because test case issue, this regression not found. the issue only exists on master branch. ### How I did it Fix TACACS local accounting disabled when debug flag disabled. #### How to verify it Pass all UT. Fix TACACS accounting UT to prevent regression. ### Tested branch (Please provide the tested image version) - [] SONiC.master-16482.360728-2c8b4066f #### Description for the changelog Fix TACACS local accounting disabled when debug flag disabled.
|
There is a bug in this PR, when backport, the fix PR also need backport: #18357 |
liuh-80
added a commit
to liuh-80/sonic-buildimage
that referenced
this pull request
May 24, 2024
…ic-net#16482) Ignore TACACS accounting trace log when debug disabled. #### Why I did it TACACS accounting trace log is only for debug, improve code to not generate trace log when debug disabled. ##### Work item tracking - Microsoft ADO: 25270078 #### How I did it Ignore TACACS accounting trace log when debug disabled. #### How to verify it Pass all UT. Manually verified the auditd-tacplus not generate trace log when debug disabled. ### Description for the changelog Ignore TACACS accounting trace log when debug disabled.
liuh-80
added a commit
to liuh-80/sonic-buildimage
that referenced
this pull request
May 24, 2024
Fix TACACS local accounting disabled when debug flag disabled. #### Why I did it TACACS local accounting use trace() method to output local accounting log, following PR disable trace log when debug flag disabled, sonic-net#16482 Because test case issue, this regression not found. the issue only exists on master branch. ### How I did it Fix TACACS local accounting disabled when debug flag disabled. #### How to verify it Pass all UT. Fix TACACS accounting UT to prevent regression. ### Tested branch (Please provide the tested image version) - [] SONiC.master-16482.360728-2c8b4066f #### Description for the changelog Fix TACACS local accounting disabled when debug flag disabled.
liuh-80
added a commit
to liuh-80/sonic-buildimage
that referenced
this pull request
May 24, 2024
…ic-net#16482) Ignore TACACS accounting trace log when debug disabled. #### Why I did it TACACS accounting trace log is only for debug, improve code to not generate trace log when debug disabled. ##### Work item tracking - Microsoft ADO: 25270078 #### How I did it Ignore TACACS accounting trace log when debug disabled. #### How to verify it Pass all UT. Manually verified the auditd-tacplus not generate trace log when debug disabled. ### Description for the changelog Ignore TACACS accounting trace log when debug disabled.
liuh-80
added a commit
to liuh-80/sonic-buildimage
that referenced
this pull request
May 24, 2024
Fix TACACS local accounting disabled when debug flag disabled. #### Why I did it TACACS local accounting use trace() method to output local accounting log, following PR disable trace log when debug flag disabled, sonic-net#16482 Because test case issue, this regression not found. the issue only exists on master branch. ### How I did it Fix TACACS local accounting disabled when debug flag disabled. #### How to verify it Pass all UT. Fix TACACS accounting UT to prevent regression. ### Tested branch (Please provide the tested image version) - [] SONiC.master-16482.360728-2c8b4066f #### Description for the changelog Fix TACACS local accounting disabled when debug flag disabled.
This was referenced May 24, 2024
yxieca
pushed a commit
that referenced
this pull request
May 28, 2024
…d. (#19060) * [TACACS] Ignore TACACS accounting trace log when debug disabled. (#16482) Ignore TACACS accounting trace log when debug disabled. #### Why I did it TACACS accounting trace log is only for debug, improve code to not generate trace log when debug disabled. ##### Work item tracking - Microsoft ADO: 25270078 #### How I did it Ignore TACACS accounting trace log when debug disabled. #### How to verify it Pass all UT. Manually verified the auditd-tacplus not generate trace log when debug disabled. ### Description for the changelog Ignore TACACS accounting trace log when debug disabled. * Fix tacacs local accounting break. (#18357) Fix TACACS local accounting disabled when debug flag disabled. #### Why I did it TACACS local accounting use trace() method to output local accounting log, following PR disable trace log when debug flag disabled, #16482 Because test case issue, this regression not found. the issue only exists on master branch. ### How I did it Fix TACACS local accounting disabled when debug flag disabled. #### How to verify it Pass all UT. Fix TACACS accounting UT to prevent regression. ### Tested branch (Please provide the tested image version) - [] SONiC.master-16482.360728-2c8b4066f #### Description for the changelog Fix TACACS local accounting disabled when debug flag disabled.
StormLiangMS
pushed a commit
that referenced
this pull request
May 31, 2024
…d. (#19061) Why I did it TACACS accounting trace log is only for debug, improve code to not generate trace log when debug disabled. Manually cherry-pick following 2 PR, because fir PR has a code bug, PR validation will block it: #16482 #18357 Work item tracking Microsoft ADO: 25270078 How I did it Ignore TACACS accounting trace log when debug disabled. How to verify it Pass all UT. Manually verified the auditd-tacplus not generate trace log when debug disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore TACACS accounting trace log when debug disabled.
Why I did it
TACACS accounting trace log is only for debug, improve code to not generate trace log when debug disabled.
Work item tracking
How I did it
Ignore TACACS accounting trace log when debug disabled.
How to verify it
Pass all UT.
Manually verified the auditd-tacplus not generate trace log when debug disabled.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
will updated with this PR image later.
Description for the changelog
Ignore TACACS accounting trace log when debug disabled.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)