-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add show dhcp_relay ipv4 counter entry, fix interface name offset issue #16507
Merged
StormLiangMS
merged 1 commit into
sonic-net:master
from
jcaiMR:dev/jcai_show_dhcpv4_counter_fix
Sep 11, 2023
Merged
Add show dhcp_relay ipv4 counter entry, fix interface name offset issue #16507
StormLiangMS
merged 1 commit into
sonic-net:master
from
jcaiMR:dev/jcai_show_dhcpv4_counter_fix
Sep 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StormLiangMS
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
…ue (sonic-net#16507) Why I did it Add another cli entry: show dhcp_relay ipv4 counter Fix get all interface offset issue Work item tracking Microsoft ADO (17271822): How I did it show dhcp_relay ipv4 counter -i [ifname] show dhcp4relay_counters counts -i [ifname] How to verify it show dhcp4relay_counters counts | more 10 Message Type Ethernet144(RX)
yaqiangz
added a commit
to yaqiangz/sonic-buildimage
that referenced
this pull request
May 31, 2024
…fset issue (sonic-net#16507)" This reverts commit 9c1c82e.
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 5, 2024
* Revert "add show dhcp_relay ipv4 counter entry, fix interface name offset issue (sonic-net#16507)" This reverts commit 9c1c82e. * Revert "[dhcp-relay]: dhcp/dhcpv6 per interface counter support (sonic-net#16377)" This reverts commit a522a63. * Remove test_show_dhcp_relay_ipv4_counter_with_enabled_dhcp_server
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
* Revert "add show dhcp_relay ipv4 counter entry, fix interface name offset issue (sonic-net#16507)" This reverts commit 9c1c82e. * Revert "[dhcp-relay]: dhcp/dhcpv6 per interface counter support (sonic-net#16377)" This reverts commit a522a63. * Remove test_show_dhcp_relay_ipv4_counter_with_enabled_dhcp_server
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 5, 2024
* Revert "add show dhcp_relay ipv4 counter entry, fix interface name offset issue (sonic-net#16507)" This reverts commit 9c1c82e. * Revert "[dhcp-relay]: dhcp/dhcpv6 per interface counter support (sonic-net#16377)" This reverts commit a522a63. * Remove test_show_dhcp_relay_ipv4_counter_with_enabled_dhcp_server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add another cli entry: show dhcp_relay ipv4 counter
Fix get all interface offset issue
Work item tracking
How I did it
show dhcp_relay ipv4 counter -i [ifname]
show dhcp4relay_counters counts -i [ifname]
How to verify it
show dhcp4relay_counters counts | more 10
Message Type Ethernet144(RX)
Message Type Ethernet144(TX)
Message Type Ethernet76(RX)
Message Type Ethernet76(TX)
show dhcp_relay ipv4 counters -i Vlan1000
Message Type Vlan1000(RX)
Message Type Vlan1000(TX)
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)