Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show dhcp_relay ipv4 counter entry, fix interface name offset issue #16507

Merged

Conversation

jcaiMR
Copy link
Contributor

@jcaiMR jcaiMR commented Sep 10, 2023

Why I did it

Add another cli entry: show dhcp_relay ipv4 counter
Fix get all interface offset issue

Work item tracking
  • Microsoft ADO (17271822):

How I did it

show dhcp_relay ipv4 counter -i [ifname]
show dhcp4relay_counters counts -i [ifname]

How to verify it

show dhcp4relay_counters counts | more 10
Message Type Ethernet144(RX)


   Unknown                  0
  Discover                  0
     Offer                  0
   Request                  0
   Decline                  0
       Ack                  0
       Nak                  0
   Release                  0
    Inform                  0

Message Type Ethernet144(TX)


       Ack                  1
   Decline                  0
  Discover                  1
    Inform                  0
       Nak                  0
     Offer                  1
   Release                  0
   Request                  0
   Unknown                  0

Message Type Ethernet76(RX)


   Unknown                 0
  Discover                 0
     Offer                 0
   Request                 0
   Decline                 0
       Ack                 0
       Nak                 0
   Release                 0
    Inform                 0

Message Type Ethernet76(TX)


       Ack                 0
   Decline                 0
  Discover                 7
    Inform                 0
       Nak                 0
     Offer                 0
   Release                 0
   Request                21
   Unknown                 0

show dhcp_relay ipv4 counters -i Vlan1000
Message Type Vlan1000(RX)


       Ack               0
   Decline               0
  Discover               2
    Inform               0
       Nak               0
     Offer               0
   Release               0
   Request               6
   Unknown               0

Message Type Vlan1000(TX)


       Ack              57
   Decline               0
  Discover               0
    Inform               0
       Nak               0
     Offer              57
   Release               0
   Request               0
   Unknown               0

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@jcaiMR jcaiMR marked this pull request as ready for review September 10, 2023 12:33
@jcaiMR jcaiMR requested a review from lguohan as a code owner September 10, 2023 12:33
@jcaiMR jcaiMR requested a review from yaqiangz September 10, 2023 12:33
Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 9c1c82e into sonic-net:master Sep 11, 2023
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
…ue (sonic-net#16507)

Why I did it
Add another cli entry: show dhcp_relay ipv4 counter
Fix get all interface offset issue

Work item tracking
Microsoft ADO (17271822):
How I did it
show dhcp_relay ipv4 counter -i [ifname]
show dhcp4relay_counters counts -i [ifname]

How to verify it
show dhcp4relay_counters counts | more 10
Message Type Ethernet144(RX)
yaqiangz added a commit to yaqiangz/sonic-buildimage that referenced this pull request May 31, 2024
yxieca pushed a commit that referenced this pull request Jun 5, 2024
* Revert "add show dhcp_relay ipv4 counter entry, fix interface name offset issue (#16507)"

This reverts commit 9c1c82e.

* Revert "[dhcp-relay]: dhcp/dhcpv6 per interface counter support (#16377)"

This reverts commit a522a63.

* Remove test_show_dhcp_relay_ipv4_counter_with_enabled_dhcp_server
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jun 5, 2024
* Revert "add show dhcp_relay ipv4 counter entry, fix interface name offset issue (sonic-net#16507)"

This reverts commit 9c1c82e.

* Revert "[dhcp-relay]: dhcp/dhcpv6 per interface counter support (sonic-net#16377)"

This reverts commit a522a63.

* Remove test_show_dhcp_relay_ipv4_counter_with_enabled_dhcp_server
mssonicbld pushed a commit that referenced this pull request Jun 5, 2024
* Revert "add show dhcp_relay ipv4 counter entry, fix interface name offset issue (#16507)"

This reverts commit 9c1c82e.

* Revert "[dhcp-relay]: dhcp/dhcpv6 per interface counter support (#16377)"

This reverts commit a522a63.

* Remove test_show_dhcp_relay_ipv4_counter_with_enabled_dhcp_server
arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this pull request Jul 26, 2024
* Revert "add show dhcp_relay ipv4 counter entry, fix interface name offset issue (sonic-net#16507)"

This reverts commit 9c1c82e.

* Revert "[dhcp-relay]: dhcp/dhcpv6 per interface counter support (sonic-net#16377)"

This reverts commit a522a63.

* Remove test_show_dhcp_relay_ipv4_counter_with_enabled_dhcp_server
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Sep 5, 2024
* Revert "add show dhcp_relay ipv4 counter entry, fix interface name offset issue (sonic-net#16507)"

This reverts commit 9c1c82e.

* Revert "[dhcp-relay]: dhcp/dhcpv6 per interface counter support (sonic-net#16377)"

This reverts commit a522a63.

* Remove test_show_dhcp_relay_ipv4_counter_with_enabled_dhcp_server
mssonicbld pushed a commit that referenced this pull request Sep 7, 2024
* Revert "add show dhcp_relay ipv4 counter entry, fix interface name offset issue (#16507)"

This reverts commit 9c1c82e.

* Revert "[dhcp-relay]: dhcp/dhcpv6 per interface counter support (#16377)"

This reverts commit a522a63.

* Remove test_show_dhcp_relay_ipv4_counter_with_enabled_dhcp_server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants