Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ecmp hash polarization by enable hash seed/offset config on T1 and upgrade xgs SAI to 8.4.35.0 #17505

Merged

Conversation

Gfrom2016
Copy link
Contributor

@Gfrom2016 Gfrom2016 commented Dec 14, 2023

Why I did it

To fix ecmp hash polarization issue.

Work item tracking
  • Microsoft ADO (number only): 26085143

How I did it

Add sai_hash_seed_config_hash_offset_enable=1 in all config.bcm that Broadcom T1 uses.

HardwareSku
Force10-S6100-T1
Force10-S6100-ITPAC-T1
Force10-S6100
Celestica-DX010-C32
Arista-7260CX3-C64
Arista-7060CX-32S-Q32
Arista-7060CX-32S-C32-T1
Arista-7060CX-32S-C32
Arista-7050QX32S-Q32
Arista-7050QX-32S-S4Q31
Arista-7050-QX32
Arista-7050-QX-32S
Include Broadcom's fix by upgrading xgs SAI version to 8.4.35.0.
  • 8.4.35.0: [CSP 00012324019] back-porting SONIC-75006 to SAI8.4
  • 8.4.34.0:
    • [CSP 00012318293] back-porting SONIC-81534 to SAI8.4;
    • ECMP LB traffic polarization, configure hash_offset along with hash_seed attr

Run qual with only xgs SAI version upgraded to 8.4.35.0:
on TH2: https://elastictest.org/scheduler/testplan/6579b36ccfacd86e78e3e885?leftSideViewMode=detail&prop=status&order=ascending
on TH: https://elastictest.org/scheduler/testplan/657a75f8c1d3b51fc1d585b4?leftSideViewMode=detail&prop=status&order=ascending

How to verify it

use tests/ecmp/test_ecmp_sai_value.py to verify.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@Gfrom2016 Gfrom2016 requested a review from lguohan as a code owner December 14, 2023 09:12
Signed-off-by: zitingguo-ms <[email protected]>
Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 1a0268c into sonic-net:202305 Dec 15, 2023
abdosi added a commit to sonic-net/sonic-mgmt that referenced this pull request Mar 7, 2024
As part of PR: #11126 ASIC to neighbor mapping was changes for all Broadcom platforms to handle sonic-net/sonic-buildimage#17505. But (sonic-net/sonic-buildimage#17505 did not make change for TD3 platforms so reverting mapping back to old one .
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Mar 22, 2024
…net#11914)

As part of PR: sonic-net#11126 ASIC to neighbor mapping was changes for all Broadcom platforms to handle sonic-net/sonic-buildimage#17505. But (sonic-net/sonic-buildimage#17505 did not make change for TD3 platforms so reverting mapping back to old one .
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Mar 22, 2024
…net#11914)

As part of PR: sonic-net#11126 ASIC to neighbor mapping was changes for all Broadcom platforms to handle sonic-net/sonic-buildimage#17505. But (sonic-net/sonic-buildimage#17505 did not make change for TD3 platforms so reverting mapping back to old one .
mssonicbld pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Mar 22, 2024
As part of PR: #11126 ASIC to neighbor mapping was changes for all Broadcom platforms to handle sonic-net/sonic-buildimage#17505. But (sonic-net/sonic-buildimage#17505 did not make change for TD3 platforms so reverting mapping back to old one .
mssonicbld pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Mar 22, 2024
As part of PR: #11126 ASIC to neighbor mapping was changes for all Broadcom platforms to handle sonic-net/sonic-buildimage#17505. But (sonic-net/sonic-buildimage#17505 did not make change for TD3 platforms so reverting mapping back to old one .
@Gfrom2016 Gfrom2016 deleted the fix_ecmp_hash_polarization_202305 branch June 17, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants