-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ecmp hash polarization by enable hash seed/offset config on T1 and upgrade xgs SAI to 8.4.35.0 #17505
Merged
StormLiangMS
merged 3 commits into
sonic-net:202305
from
Gfrom2016:fix_ecmp_hash_polarization_202305
Dec 15, 2023
Merged
Fix ecmp hash polarization by enable hash seed/offset config on T1 and upgrade xgs SAI to 8.4.35.0 #17505
StormLiangMS
merged 3 commits into
sonic-net:202305
from
Gfrom2016:fix_ecmp_hash_polarization_202305
Dec 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zitingguo-ms <[email protected]>
Signed-off-by: zitingguo-ms <[email protected]>
device/arista/x86_64-arista_7050_qx32s/Arista-7050QX-32S-S4Q31/sai.profile.j2
Show resolved
Hide resolved
device/arista/x86_64-arista_7050_qx32s/Arista-7050QX32S-Q32/sai.profile.j2
Show resolved
Hide resolved
device/arista/x86_64-arista_7060_cx32s/Arista-7060CX-32S-C32/sai.profile.j2
Show resolved
Hide resolved
Signed-off-by: zitingguo-ms <[email protected]>
StormLiangMS
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7 tasks
7 tasks
5 tasks
5 tasks
abdosi
added a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Mar 7, 2024
As part of PR: #11126 ASIC to neighbor mapping was changes for all Broadcom platforms to handle sonic-net/sonic-buildimage#17505. But (sonic-net/sonic-buildimage#17505 did not make change for TD3 platforms so reverting mapping back to old one .
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 22, 2024
…net#11914) As part of PR: sonic-net#11126 ASIC to neighbor mapping was changes for all Broadcom platforms to handle sonic-net/sonic-buildimage#17505. But (sonic-net/sonic-buildimage#17505 did not make change for TD3 platforms so reverting mapping back to old one .
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 22, 2024
…net#11914) As part of PR: sonic-net#11126 ASIC to neighbor mapping was changes for all Broadcom platforms to handle sonic-net/sonic-buildimage#17505. But (sonic-net/sonic-buildimage#17505 did not make change for TD3 platforms so reverting mapping back to old one .
mssonicbld
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Mar 22, 2024
As part of PR: #11126 ASIC to neighbor mapping was changes for all Broadcom platforms to handle sonic-net/sonic-buildimage#17505. But (sonic-net/sonic-buildimage#17505 did not make change for TD3 platforms so reverting mapping back to old one .
mssonicbld
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Mar 22, 2024
As part of PR: #11126 ASIC to neighbor mapping was changes for all Broadcom platforms to handle sonic-net/sonic-buildimage#17505. But (sonic-net/sonic-buildimage#17505 did not make change for TD3 platforms so reverting mapping back to old one .
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To fix ecmp hash polarization issue.
Work item tracking
How I did it
Add sai_hash_seed_config_hash_offset_enable=1 in all config.bcm that Broadcom T1 uses.
Run qual with only xgs SAI version upgraded to 8.4.35.0:
on TH2: https://elastictest.org/scheduler/testplan/6579b36ccfacd86e78e3e885?leftSideViewMode=detail&prop=status&order=ascending
on TH: https://elastictest.org/scheduler/testplan/657a75f8c1d3b51fc1d585b4?leftSideViewMode=detail&prop=status&order=ascending
How to verify it
use tests/ecmp/test_ecmp_sai_value.py to verify.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)