Made pmon feature delayed flag as jinja template #19482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peer device's Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
higher value so that BGP learnt default route is higher priority. Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
save as `slice_type` as part of DEVICE_METADATA Signed-off-by: Abhishek Dosi <[email protected]>
…graph and" This reverts commit 0f2d26d.
save as `slice_type` as part of DEVICE_METADATA for Chassis Device type Signed-off-by: Abhishek Dosi <[email protected]>
pmon need to enable asap to detect ASIC's on Supervisor. pmonm need to enable asap for bring-up of 400G ports on LC's fast becuase of CMIS state machine present in PMON. Signed-off-by: Abhishek Dosi <[email protected]>
|
@anamehra @mlok-nokia for viz. |
arlakshm
previously approved these changes
Jul 9, 2024
|
/Azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
|
@arlakshm : please reapprove this. |
arlakshm
previously approved these changes
Jul 13, 2024
Signed-off-by: Abhishek Dosi <[email protected]>
mlok-nokia
reviewed
Jul 22, 2024
| @@ -38,7 +38,7 @@ | |||
| {%- set features = [("bgp", "{% if not DEVICE_RUNTIME_METADATA['ETHERNET_PORTS_PRESENT'] or ('CHASSIS_METADATA' in DEVICE_RUNTIME_METADATA and DEVICE_RUNTIME_METADATA['CHASSIS_METADATA']['module_type'] in ['supervisor']) %}disabled{% else %}enabled{% endif %}", false, "enabled"), | |||
| ("database", "always_enabled", false, "always_enabled"), | |||
| ("lldp", "enabled", true, "enabled"), | |||
| ("pmon", "enabled", true, "enabled"), | |||
| ("pmon", "enabled", "{% if 'type' in DEVICE_METADATA['localhost'] and DEVICE_METADATA['localhost']['type'] == 'SpineRouter' %}false{% else %}true{% endif %}", "enabled"), | |||
There was a problem hiding this comment.
This PR works with PR sonic-net/sonic-host-services#135
But delayed value "true/false" in init_cfg.json.j2 is not matched the expected value which in the featured line 79 in sonic-net/sonic-host-services#135 change. The defined value should be "True/False".
This change causes the system fails to start PMON
There was a problem hiding this comment.
Good catch, I suppose it's because of the removal of 'lower()' function, not sure why Abhishek changed this behavior.
Let me draft another PR and see.
|
Fix the issue and advance sonic-host-service sub-module |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
|
#19657 merged, closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
To fix: #19126
Depends on: sonic-net/sonic-host-services#135 and it's submodule update.
Why I did:
PMON was delayed originally for faster uptime of data plane related services in case of fast/warm reboot.
This is not needed for T2/SpineRouter . Infact we need PMON to be up asap because of:
How I verify:
Manual Verification and UT has been added in sonic-net/sonic-host-services#135