Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Arista]: Fix TH5 egress pool creation failure with BCM YAML … #20245

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Revert "[Arista]: Fix TH5 egress pool creation failure with BCM YAML … #20245

merged 1 commit into from
Sep 16, 2024

Conversation

Janetxxx
Copy link
Contributor

@Janetxxx Janetxxx commented Sep 12, 2024

This reverts commit 0344d4a.

Why I did it

Because the issue arose from mixing 200G and 400G ports, but the deployment environment does not involve this mix, the issue will not occur, so this change is not necessary.

Work item tracking
  • Microsoft ADO (number only): 28775282

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202405

Tested branch (Please provide the tested image version)

  • 20231110.17

Description for the changelog

Link to config_db schema for YANG module changes

N/A

A picture of a cute animal (not mandatory but encouraged)

…file and SAI update on 07/16 (#19640)"

This reverts commit 0344d4a.
@Janetxxx Janetxxx requested a review from r12f September 12, 2024 14:01
Copy link
Contributor

@r12f r12f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! @Janetxxx , you might need to retry the test. I believe the kvm-test are not relavant to this PR.

@r12f
Copy link
Contributor

r12f commented Sep 12, 2024

@rick-arista as FYI .

@r12f
Copy link
Contributor

r12f commented Sep 12, 2024

@kperumalbfn as FYI too.

@kperumalbfn
Copy link
Contributor

@rick-arista Please check the latest ingress/egress pool size.

@r12f
Copy link
Contributor

r12f commented Sep 16, 2024

hi @Janetxxx , since we are hitting this conflict, we will have to manually cherry pick this change to 202405 once this PR is merged.

image

@Janetxxx
Copy link
Contributor Author

@r12f I will do it once this PR gets merged.

@yxieca yxieca merged commit e40ff63 into sonic-net:master Sep 16, 2024
23 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Sep 16, 2024
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #20272

mssonicbld pushed a commit that referenced this pull request Sep 16, 2024
Janetxxx added a commit to Janetxxx/sonic-buildimage that referenced this pull request Sep 17, 2024
aidan-gallagher pushed a commit to aidan-gallagher/sonic-buildimage that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants