Fix tuning values in the media_settings.json of 7800r3a_36d2_lc #20283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert negative value to unsigned int32
wenyiz2021
approved these changes
Sep 18, 2024
arlakshm
approved these changes
Sep 18, 2024
|
We do not need this change on |
Hi Arvind - We need this in the master branch. I can create another PR for the master. |
@abohanyang Nathan created master PR |
saksarav-nokia
pushed a commit
to saksarav-nokia/sonic-buildimage
that referenced
this pull request
Oct 9, 2024
…2_lc (sonic-net#20308) Master PR of sonic-net#20283 which was made for 202405
aidan-gallagher
pushed a commit
to aidan-gallagher/sonic-buildimage
that referenced
this pull request
Nov 16, 2024
…2_lc (sonic-net#20308) Master PR of sonic-net#20283 which was made for 202405
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Need to fix the tuning values in the media_settings.json file because today, the parser of media_settings.json expects unsigned int32 values, instead of signed int32 values.
Work item tracking
N/A
How I did it
N/A
How to verify it
Without this fix, the TX FIR tuning may fail, displaying an error message like, 'parsePortSerdes: Failed to parse field(pre1): Invalid argument: '-0x8''
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Change tuning value from signed int32 to unsigned int32
Link to config_db schema for YANG module changes
N/A
A picture of a cute animal (not mandatory but encouraged)
N/A