Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker-fpm-frr] Change the ownership of files within /etc/frr/ to frr #3388

Merged
merged 1 commit into from
Oct 15, 2019
Merged

[docker-fpm-frr] Change the ownership of files within /etc/frr/ to frr #3388

merged 1 commit into from
Oct 15, 2019

Conversation

shikenghua
Copy link
Contributor

@shikenghua shikenghua commented Aug 27, 2019

- What I did
The owner of the files generated by start.sh (/etc/frr/*.conf) is root if it is a new file. This will cause error when executing "copy running-config startup-config" in vtysh because of privilege issue. The owner of all conf files within /etc/frr/ need to be changed to frr.
Note: The "RUN chown -R ${frr_user_uid}:${frr_user_gid} /etc/frr/" command in Dockerfile only works on existing files.

- How I did it
Add "chown -R frr:frr /etc/frr/" in start.sh

- How to verify it
Test with "copy running-config startup-config" command in vtysh.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

The owner of the generated files (/etc/frr/*.conf) by start.sh is root if it is a new file.
This will cause error when executing "copy running-config startup-config" in vtysh because of privilege issue.
@mikelazar
Copy link
Contributor

This is really useful - otherwise changes made with "write mem" from vtysh cannot be saved.

Would it be possible to merge this pull request soon ?

@shikenghua
Copy link
Contributor Author

This is really useful - otherwise changes made with "write mem" from vtysh cannot be saved.

Would it be possible to merge this pull request soon ?

I have no idea. It is a very simple change and the pull request was submitted 6 weeks ago but no one review it yet. Maybe just wait...

@pavel-shirshov pavel-shirshov self-assigned this Oct 15, 2019
@pavel-shirshov pavel-shirshov merged commit 9032ad8 into sonic-net:master Oct 15, 2019
@shikenghua shikenghua deleted the chown_etc_frr branch October 16, 2019 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants