-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt per-port buffer & qos profile apply on mellanox #3543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenda Ni <[email protected]>
wendani
requested review from
andriymoroz-mlnx,
lguohan,
renukamanavalan and
liat-grozovik
October 1, 2019 01:19
renukamanavalan
approved these changes
Oct 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Wenda!
@wendani: What does the "Request for configlet" label signify? All of our "Request for ..." labels indicate a PR that needs to be cherry-picked to another release branch after merging. This doesn't fit the pattern. |
lguohan
reviewed
Oct 10, 2019
wendani
force-pushed
the
split_mlnx_master
branch
from
October 18, 2019 01:00
741e8b8
to
af38833
Compare
lguohan
approved these changes
Oct 18, 2019
andriymoroz-mlnx
approved these changes
Oct 18, 2019
retest vs please |
renukamanavalan
pushed a commit
that referenced
this pull request
Oct 24, 2019
Signed-off-by: Wenda Ni <[email protected]>
yxieca
pushed a commit
that referenced
this pull request
Nov 7, 2019
Signed-off-by: Wenda Ni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried
sudo config load_minigraph -y
on mlnx dutSigned-off-by: Wenda Ni [email protected]
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)