[makefile] build Jessie slave unless NOJESSIE is specified #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ying Xie <[email protected]>
qiluo-msft
approved these changes
Oct 1, 2019
jleveque
approved these changes
Oct 1, 2019
jleveque
approved these changes
Oct 2, 2019
|
retest vsimage please |
qiluo-msft
reviewed
Oct 2, 2019
| @@ -17,4 +17,7 @@ endif | |||
|
|
|||
| clean reset init configure showtag sonic-slave-build sonic-slave-bash : | |||
| @echo "+++ Making $@ +++" | |||
| ifeq ($(NOJESSIE), 0) | |||
| make -f Makefile.work $@ | |||
| endif | |||
sschlafman
pushed a commit
to sschlafman/sonic-buildimage
that referenced
this pull request
Oct 15, 2024
…atically (sonic-net#20458) #### Why I did it src/sonic-utilities ``` * 910252c9 - (HEAD -> master, origin/master, origin/HEAD) [Mellanox] Rename SKU to Mellanox-SN5600-C256X1 (sonic-net#3546) (3 days ago) [DavidZagury] ``` #### How I did it #### How to verify it #### Description for the changelog
aidan-gallagher
pushed a commit
to aidan-gallagher/sonic-buildimage
that referenced
this pull request
Nov 16, 2024
…atically (sonic-net#20458) #### Why I did it src/sonic-utilities ``` * 910252c9 - (HEAD -> master, origin/master, origin/HEAD) [Mellanox] Rename SKU to Mellanox-SN5600-C256X1 (sonic-net#3546) (3 days ago) [DavidZagury] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a method in master branch to build Jessie slave docker. This option is currently on by default unless NOJESSIE=1 is specified. The default for NOJESSIE should probably becomes 1 at some point when we fully understand what needs Jessie slave docker where from the master branch.