[FRR]: Use stg in a proper way. #3589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wangshengjun <[email protected]>
Signed-off-by: wangshengjun <[email protected]>
src/sonic-frr/Makefile
Outdated
| @@ -4,20 +4,24 @@ SHELL = /bin/bash | |||
|
|
|||
| MAIN_TARGET = $(FRR) | |||
| DERIVED_TARGET = $(FRR_PYTHONTOOLS) $(FRR_DBG) $(FRR_SNMP) $(FRR_SNMP_DBG) | |||
| BRANCH = $(shell date +%Y%m%d\.%H%M%S) | |||
| FRR_VERSION = 7.1 | |||
There was a problem hiding this comment.
You don't need to define it. It's exported from rules/frr.mk: export FRR_VERSION FRR_SUBVERSION along with the subversion so we can just use it.
There was a problem hiding this comment.
Thanks for your comment! I will remove it.
Signed-off-by: wangshengjun <[email protected]>
nikos-github
approved these changes
Oct 12, 2019
nikos-github
approved these changes
Oct 12, 2019
pavel-shirshov
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wangshengjun [email protected]
- What I did
use stg branch instead of git branch.
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)