[minigraph.py] Generate items needed by streaming telemetry service #3759
Conversation
src/sonic-config-engine/minigraph.py
Outdated
| 'server_crt': '/etc/sonic/telemetry/streamingtelemetryserver.cer', | ||
| 'server_key': '/etc/sonic/telemetry/streamingtelemetryclient.key', | ||
| 'ca_crt': '/etc/sonic/telemetry/dsmsroot.cer' |
There was a problem hiding this comment.
What if we need other certificates on the SONiC box? Maybe the keys are too generic: "server_crt", "server_key", "ca_crt". Maybe we need to prefix them with the component they're used for, e.g., "telemetry_server_crt", "telemetry_server_key", "telemetry_ca_crt", etc.
Or maybe this should be moved out of the DEVICE_METADATA table and into the TELEMETRY table below?
@lguohan: What is your opinion here?
There was a problem hiding this comment.
Hi Joe, such keys are used in telemetry contrainers and already defined:
https://github.com/Azure/sonic-buildimage/blob/master/dockers/docker-sonic-telemetry/telemetry.sh
If we need change, we need change this place as well. It will break other partner using this feature now, if we device to use other key names.
There was a problem hiding this comment.
Ah. Good to know.
@lguohan: Should we merge this as-is and deal with making changes to support other certificates if and when we need them?
There was a problem hiding this comment.
@hui-ma: I think we can go ahead and merge this as-is for now, but I think we need to go back and think about a way to restructure this in order for SONiC to manage multiple keys/certs.
jleveque
changed the title
- What I did
Added new keys to config DB needed for telemetry agent
- How I did it
- How to verify it
config load_minigraph. Once successful new added entries will appear in config_db
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)