Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dockers] Rename 'docker-lldp-sv2' to 'docker-lldp' #4700

Merged
merged 1 commit into from
Jun 9, 2020
Merged

[dockers] Rename 'docker-lldp-sv2' to 'docker-lldp' #4700

merged 1 commit into from
Jun 9, 2020

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Jun 4, 2020

The -sv2 suffix was used to differentiate SNMP Dockers when we transitioned from "SONiCv1" to "SONiCv2", about four years ago. The old Docker materials were removed long ago; there is no need to keep this suffix. Removing it aligns the name with all the other Dockers.

@jleveque jleveque requested review from lguohan and qiluo-msft June 4, 2020 07:26
@jleveque jleveque self-assigned this Jun 4, 2020
@jleveque
Copy link
Contributor Author

jleveque commented Jun 4, 2020

Retest vsimage please

@jleveque
Copy link
Contributor Author

jleveque commented Jun 4, 2020

Retest broadcom please

@jleveque
Copy link
Contributor Author

jleveque commented Jun 4, 2020

Retest mellanox please

1 similar comment
@jleveque
Copy link
Contributor Author

jleveque commented Jun 4, 2020

Retest mellanox please

@jleveque
Copy link
Contributor Author

jleveque commented Jun 4, 2020

Retest vsimage please

@jleveque
Copy link
Contributor Author

jleveque commented Jun 4, 2020

Retest mellanox please

@lguohan
Copy link
Collaborator

lguohan commented Jun 7, 2020

retest vsimage please

@jleveque
Copy link
Contributor Author

jleveque commented Jun 8, 2020

Retest mellanox please

@jleveque
Copy link
Contributor Author

jleveque commented Jun 8, 2020

Retest vsimage please

1 similar comment
@jleveque
Copy link
Contributor Author

jleveque commented Jun 8, 2020

Retest vsimage please

@lguohan lguohan merged commit 9b27efd into sonic-net:master Jun 9, 2020
@jleveque jleveque deleted the rename_lldp_docker branch June 9, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants