[Multi-Asic] Fix for multi-asic where we should allow namespace docker local communication on its docker/eth0 ip #5364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
communication on docker eth0 ip . Without this TCP Connection to Redis does not happen in namespace. Signed-off-by: Abhishek Dosi <abdosi@abdosi-ubuntu-vm0.nwp1qucpfg5ejooejenqshkj3e.cx.internal.cloudapp.net>
jleveque
approved these changes
Sep 12, 2020
judyjoseph
approved these changes
Sep 13, 2020
|
do we need to modify the control plane acl test to adapt this change? |
Yes @lguohan will update(to-do work item) caclmgr test case as of part of multi-asic test case's enhancement. Test-case added : sonic-net/sonic-mgmt#3070 |
lguohan
approved these changes
Sep 16, 2020
abdosi
added a commit
that referenced
this pull request
Sep 19, 2020
…5364) communication on docker eth0 ip . Without this TCP Connection to Redis does not happen in namespace. Signed-off-by: Abhishek Dosi <abdosi@abdosi-ubuntu-vm0.nwp1qucpfg5ejooejenqshkj3e.cx.internal.cloudapp.net> Co-authored-by: Abhishek Dosi <abdosi@abdosi-ubuntu-vm0.nwp1qucpfg5ejooejenqshkj3e.cx.internal.cloudapp.net>
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…onic-net#5364) communication on docker eth0 ip . Without this TCP Connection to Redis does not happen in namespace. Signed-off-by: Abhishek Dosi <abdosi@abdosi-ubuntu-vm0.nwp1qucpfg5ejooejenqshkj3e.cx.internal.cloudapp.net> Co-authored-by: Abhishek Dosi <abdosi@abdosi-ubuntu-vm0.nwp1qucpfg5ejooejenqshkj3e.cx.internal.cloudapp.net>
abdosi
added a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Mar 2, 2021
Enhanced test_cacl_application.py for multi-asic platforms. Also it adds new test case to cover all multi-asic specific changes as done in PR's:- sonic-net/sonic-buildimage#5022 sonic-net/sonic-buildimage#5420 sonic-net/sonic-buildimage#5364 sonic-net/sonic-buildimage#6765 Also fix some of API in common/devices.py and bug in config_facts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why/What i did:
Fix for multi-asic where we should allow namespace docker local communication on its docker/eth0 ip
. Without this TCP Connection to Redis Server running on docker eth0 ip does not happen in namespace if there is Catch all DROP Rule.
Found this issue as part of debugging
a) lldpmgrd was not able to start in namespace (uses Redis TCP Connection)
b) Feature auto restart not working for namespace docker (supervisor-proc-exit-listener also uses Redis TCP Connection)
How I verify:
After fix both issue (a) and (b) are working fine.