Fix bug with pcie-check.service

[bratashX]

Signed-off-by: Petro Bratash [email protected]

- Why I did it
pci-check.service and pcied daemon set different variables in STATE_DB.

• pci-check.service set "PCIE_STATUS|PCIE_DEVICES" variable with type string,

• pcied daemon set "PCIE_STATUS|" -> "PCIE_DEVICES" variable with type hash.

- How I did it
Change type for variable with PCI device status from string to hash ("PCIE_STATUS|PCIE_DEVICES" --> "PCIE_DEVICES" "status"), because haven't got API for work with string variable from Python.
- How to verify it

- Which release branch to backport (provide reason below if selected)

• 201811
• 201911
• 202006

- Description for the changelog

Also, in this PR fixed the issues:

• PCIE_CHK_CMD the variable contains the result of the command work's, and this result cyclically compares with EXPECTED without rescanning devices.

• Added dependency to database.service, because when pcie-check.service start before database.service will be next error:

pcie-check.sh[912]: Traceback (most recent call last):
pcie-check.sh[912]: File "/usr/bin/pcieutil", line 12, in
pcie-check.sh[912]: sys.exit(cli())
pcie-check.sh[912]: File "/usr/lib/python2.7/dist-packages/click/core.py", line 764, in call
pcie-check.sh[912]: return self.main(*args, **kwargs)
pcie-check.sh[912]: File "/usr/lib/python2.7/dist-packages/click/core.py", line 717, in main
pcie-check.sh[912]: rv = self.invoke(ctx)
pcie-check.sh[912]: File "/usr/lib/python2.7/dist-packages/click/core.py", line 1134, in invoke
pcie-check.sh[912]: Command.invoke(self, ctx)
pcie-check.sh[912]: File "/usr/lib/python2.7/dist-packages/click/core.py", line 956, in invoke
pcie-check.sh[912]: return ctx.invoke(self.callback, **ctx.params)
pcie-check.sh[912]: File "/usr/lib/python2.7/dist-packages/click/core.py", line 555, in invoke
pcie-check.sh[912]: return callback(*args, **kwargs)
pcie-check.sh[912]: File "/usr/lib/python2.7/dist-packages/pcieutil/main.py", line 75, in cli
pcie-check.sh[912]: load_platform_pcieutil()
pcie-check.sh[912]: File "/usr/lib/python2.7/dist-packages/pcieutil/main.py", line 49, in load_platform_pcieutil
pcie-check.sh[912]: platform_path, _ = device_info.get_paths_to_platform_and_hwsku_dirs()
pcie-check.sh[912]: File "/usr/local/lib/python2.7/dist-packages/sonic_py_common/device_info.py", line 213, in get_paths_to_platform_and_hwsku_dirs
pcie-check.sh[912]: hwsku_path = os.path.join(platform_path, hwsku)
pcie-check.sh[912]: File "/usr/lib/python2.7/posixpath.py", line 68, in join
pcie-check.sh[912]: if b.startswith('/'):
pcie-check.sh[912]: AttributeError: 'NoneType' object has no attribute 'startswith'

Related PR: sonic-net/sonic-platform-daemons#93
Fix for: #5349

- A picture of a cute animal (not mandatory but encouraged)

[bratashX]

@akokhan @sujinmkang , please review.

[bratashX]

@sujinmkang, please update the documentation:

• 1.4 and 1.5 -- diagrams
• 1.6 -- command