-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pmon daemons python3 build support #6176
Add pmon daemons python3 build support #6176
Conversation
The build issue will be fixed after merging sonic-net/sonic-platform-common#154 and moving submodule pointer. |
@Junchao-Mellanox: Please fix new conflicts. |
Done |
Build failures in unit tests:
Please check. |
Hi @jleveque , this issue is introduced by commit:
The error is introduced by line https://github.com/Azure/sonic-platform-daemons/blob/b674dffb717968b306b2bb967b0cbce74661a45f/sonic-xcvrd/tests/test_xcvrd.py#L9 . In this line it should import the package patch like: if sys.version_info >= (3, 3):
from unittest.mock import MagicMock, patch I have created a PR to fix this. See sonic-net/sonic-platform-daemons#135 |
@Junchao-Mellanox: Thank you for the fix! I merged it. Can you please update the submodule? |
Sure |
Retest this please |
Conflicts: dockers/docker-platform-monitor/start.sh
The file path was changed in bellow pull request, but tests in sonic-mgmt were not updated, after that PR was merged sonic-net/sonic-buildimage#6176
…latform test (#3178) The file path was changed in bellow pull request, but tests in sonic-mgmt were not updated, after that PR was merged sonic-net/sonic-buildimage#6176
…latform test (sonic-net#3178) The file path was changed in bellow pull request, but tests in sonic-mgmt were not updated, after that PR was merged sonic-net/sonic-buildimage#6176
- Why I did it
python2 is end of life and SONiC is going to support python3. This PR is going to support:
- How I did it
- How to verify it
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)