-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert snmp.yml to configdb #6205
Merged
SuvarnaMeenakshi
merged 10 commits into
sonic-net:master
from
tsvanduyn:snmp_docker_update
Dec 28, 2020
Merged
Convert snmp.yml to configdb #6205
SuvarnaMeenakshi
merged 10 commits into
sonic-net:master
from
tsvanduyn:snmp_docker_update
Dec 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
suggested changes
Dec 15, 2020
This comment has been minimized.
This comment has been minimized.
jleveque
suggested changes
Dec 15, 2020
retest this please |
1 similar comment
retest this please |
qiluo-msft
reviewed
Dec 17, 2020
qiluo-msft
reviewed
Dec 17, 2020
qiluo-msft
requested changes
Dec 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As comments
jleveque
suggested changes
Dec 18, 2020
jleveque
reviewed
Dec 18, 2020
jleveque
suggested changes
Dec 18, 2020
jleveque
previously approved these changes
Dec 18, 2020
SuvarnaMeenakshi
previously approved these changes
Dec 18, 2020
…yml_to_configdb.py will cover that.
1b36f6e
jleveque
approved these changes
Dec 19, 2020
qiluo-msft
approved these changes
Dec 19, 2020
retest vs please |
retest vsimage please |
Retest vsimage please |
SuvarnaMeenakshi
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
This PR is in preparation to move from snmp.yml to configdb. This will more closely align with other commands in sonic and use configdb as the source of truth for snmp configuration.
Note: This is the first of 2 PR's to enable this. This PR will not change any functionality but will allow the snmp.yml file info to be put into the configdb.
Once this is verified as working as expected then the updates to the Jinja2 template to only use the snmp info from the configdb and the update to the start.sh to exclude the import of data from the snmp.yml will be done. (This will allow us backward compatiblity since the snmp.yml file info will be installed in the configdb at docker container startup with the conversion script.)
Eventually we will be able to remove the need for the snmp.yml file.
- How I did it
I've created a script that takes the snmp.yml variables and converts them to the configdb format.
In addition this file was added to the dockerfile.j2 so that file will be copied in the container.
As well as updating the start.sh file to automatically run the python conversion script each time the docker container is restarted.
- How to verify it
Before docker restart:
After docker restart:
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)