[DPB|master] Update Dynamic Port Breakout Logic for flexible alias support a…

[samaity]

Signed-off-by: Sangita Maity [email protected]

Why I did it

To fix DPB| wrong aliases for interfaces issue, implimented flexible alias support design doc

[dpb|config] Fix the validation logic of breakout mode depends on this

How I did it

1. Removed "alias_at_lanes" from port-configuration file(i.e. platfrom.json)
2. Added dictionary to "breakout_modes" values. This defines the breakout modes available on the platform for this parent port, and it maps to the alias list. The alias list presents the alias names for individual ports in order under this breakout mode.

{
    "interfaces": {
        "Ethernet0": {
            "index": "1,1,1,1",
            "lanes": "0,1,2,3",
            "breakout_modes": {
                "1x100G[40G]": ["Eth1"],
                "2x50G": ["Eth1/1", "Eth1/2"],
                "4x25G[10G]": ["Eth1/1", "Eth1/2", "Eth1/3", "Eth1/4"],
                "2x25G(2)+1x50G(2)": ["Eth1/1", "Eth1/2", "Eth1/3"],
                "1x50G(2)+2x25G(2)": ["Eth1/1", "Eth1/2", "Eth1/3"]
            }
        }
}

How to verify it

config interface breakout

Which release branch to backport (provide reason below if selected)

• 201811
• 201911
• 202006
• 202012

[lguohan]

@samaity , what is the build issue?

[yxieca]

There seems to be a systematic error with the naming when breakout was done at half speeds (50G).

E.g. when 2 interfaces break to 50G, the second interface should be Ethx/3 or etpxc

This error is also noticed in PR comment.

[yxieca]

Please fix the breakout numbering when half speed breakout is involved.

[zhenggen-xu]

There seems to be a systematic error with the naming when breakout was done at half speeds (50G).

E.g. when 2 interfaces break to 50G, the second interface should be Ethx/3 or etpxc

This error is also noticed in PR comment.

Actually according to this doc, which you submitted, it was etpxb instead of etpxc: :-)
https://github.com/Azure/SONiC/blob/master/doc/sonic-port-name.md

Anyway, this alias list is really for box vendor or user to define and we don't limit to anything as for the design. And for us, we prefer to have 1/1 and 1/2. and this is inline with one of the traditional vendors.

[samaity]

To give a brief, we fixed the breakout numbering when a half-speed breakout (i.e. 2x50G) is involved for Barefoot and VS platform by modifying platform.json as requested

Barefoot

"breakout_modes": {
                "1x100G[40G]": ["Ethernet0"],
                "2x50G": ["Ethernet0", "Ethernet2"],

vs

"breakout_modes": {
                "1x100G[40G]": ["fortyGigE0/0"],
                "2x50G": ["fortyGigE0/0", "fortyGigE0/2"],

For other platforms, we are keeping it as it is. Kindly let us know if any modification is needed after the latest one. Thanks!

[samaity]

retest this please

[lguohan]

can you update the sonic utilties since the fix is merged?

[jleveque]

can you update the sonic utilties since the fix is merged?

I have advanced the submodule further in my PR: #6874

[jleveque]

@samaity: There are still build failures. Can you please check?

addressed