[Makefile.work] Add DOCKER_EXTRA_OPTS #7775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <[email protected]>
stepanblyschak
requested review from
lguohan,
qiluo-msft and
xumia
as code owners
qiluo-msft
reviewed
Jun 2, 2021
sonic-slave-buster/Dockerfile.j2
Outdated
| @@ -502,7 +502,7 @@ RUN add-apt-repository \ | |||
| stable" | |||
| RUN apt-get update | |||
| RUN apt-get install -y docker-ce=5:18.09.5~3-0~debian-buster docker-ce-cli=5:18.09.5~3-0~debian-buster | |||
| RUN echo "DOCKER_OPTS=\"--experimental --storage-driver=vfs\"" >> /etc/default/docker | |||
| RUN echo "DOCKER_OPTS=\"--experimental --storage-driver=vfs {{ EXTRA_DOCKERD_OPTS }}\"" >> /etc/default/docker | |||
There was a problem hiding this comment.
Call it DOCKER_EXTRA_OPTS?
Signed-off-by: Stepan Blyschak <[email protected]>
stepanblyschak
changed the title
qiluo-msft
approved these changes
Jun 2, 2021
|
@xumia can you please review? |
xumia
approved these changes
Jun 8, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Jun 28, 2021
#### Why I did it Usecase: export DOCKER_EXTRA_OPTS="--registry-mirror=https://some.host" - to avoid DockerHub pull rate limiting. #### How I did it Added DOCKER_EXTRA_OPTS #### How to verify it export DOCKER_EXTRA_OPTS="--registry-mirror=https://some.host" make target/sonic-mellanox.bin
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
#### Why I did it Usecase: export DOCKER_EXTRA_OPTS="--registry-mirror=https://some.host" - to avoid DockerHub pull rate limiting. #### How I did it Added DOCKER_EXTRA_OPTS #### How to verify it export DOCKER_EXTRA_OPTS="--registry-mirror=https://some.host" make target/sonic-mellanox.bin
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak [email protected]
Why I did it
Usecase:
export DOCKER_EXTRA_OPTS="--registry-mirror=https://some.host" - to avoid DockerHub pull rate limiting.
How I did it
Added DOCKER_EXTRA_OPTS
How to verify it
export DOCKER_EXTRA_OPTS="--registry-mirror=https://some.host"
make target/sonic-mellanox.bin
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)