Add platform cisco-8000 to platform path #7821
Conversation
|
Hi @xumia - can you please help with running re-test (azp run) |
platform/cisco-8000/rules.mk
Outdated
| ############################################################## | ||
|
|
||
| CISCO_PLATFORM_BRANCH := cisco-8000/master | ||
| CISCO_PLATFORM_URL := https://github.com/Cisco-8000-sonic/platform-cisco-8000.git |
There was a problem hiding this comment.
It is a private repo, we are not able to access it from public, it will be an issue when building cisco 8000 in azure pipeline. If the repo can not change to public, we can create a private pipeline for your repo https://github.com/Cisco-8000-sonic/platform-cisco-8000.git.
There was a problem hiding this comment.
Ack. Please help with creating a private pipeline if that solves your access issues, as cisco would like to keep this access privileges only to MSFT.
| CISCO_PLATFORM_URL := https://github.com/Cisco-8000-sonic/platform-cisco-8000.git | ||
| CISCO_PLATFORM_SRC=$(PLATFORM_PATH)/src | ||
|
|
||
| $(shell if [ ! -d $(CISCO_PLATFORM_SRC) ]; then git clone -b $(CISCO_PLATFORM_BRANCH) $(CISCO_PLATFORM_URL) $(CISCO_PLATFORM_SRC); fi) |
There was a problem hiding this comment.
We'd better to clone a specific commit id/tag, not branch, for version control.
There was a problem hiding this comment.
-
CISCO_PLATFORM_BRANCH Is a configureable variable. This is the first commit that brings in cisco-8000 platform into sonic-buildimage repo hence its pointing to the head of the branch. This is eventually going to be controlled by MSFT that reflects the correct commit id of the platform code in their environment.
-
As was discussed upon in mtg with Guhon and team today, the repo is accessible only to MSFT only. So privilege is necessary for accessing https://github.com/Cisco-8000-sonic/
There was a problem hiding this comment.
Looks like its failing in which seems to be a breakage of azure/master branch. There is no code intersection. Is there a fix for this issue ?
File "/sonic/src/sonic-config-engine/tests/test_j2files.py", line 108, in test_zebra_quagga
There was a problem hiding this comment.
It is another issue, build break on master(has fixed), we can re-run azp to fix it.
There was a problem hiding this comment.
which issue is this ?.
There was a problem hiding this comment.
The PR to fix master build issue: #7831
There was a problem hiding this comment.
All tests were successful. Can you please review & approve this PR
There was a problem hiding this comment.
@VenkatCisco , FYI, @liushilongbuaa is working on a feature to make git repo reproducible, when the feature enabled, a commit control file will be generated, we will only download specified commit.
There was a problem hiding this comment.
@xumia, Thanks for the update. How does that change impact this PR ?. If not can you please approve/merge it ?
There was a problem hiding this comment.
The PR is significantly updated based on the offline discussion cisco team had with the PR review team from MSFT. There are some more updates checked into the PR for review.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
What is this binary file In reply to: 857422274 |
this looks like a file that got added in 'git add' operation. Updated changes are checked in now. |
|
Hi Xuhui,
If the master build breakage issue is fixed, can you help with re-scheduling the run for this PR ?
Thanks so much for the help
Thanks//Venkat
From: xumia ***@***.***>
Reply-To: Azure/sonic-buildimage ***@***.***>
Date: Wednesday, June 9, 2021 at 9:16 PM
To: Azure/sonic-buildimage ***@***.***>
Cc: Venkat Garigipati ***@***.***>, Author ***@***.***>
Subject: Re: [Azure/sonic-buildimage] Add platform cisco-8000 to platform path (#7821)
@xumia commented on this pull request.
________________________________
In platform/cisco-8000/rules.mk<#7821 (comment)>:
@@ -0,0 +1,12 @@
+##############################################################
+## Top level platform rules.mk
+##############################################################
+
+CISCO_PLATFORM_BRANCH := cisco-8000/master
+CISCO_PLATFORM_URL := https://github.com/Cisco-8000-sonic/platform-cisco-8000.git
+CISCO_PLATFORM_SRC=$(PLATFORM_PATH)/src
+
+$(shell if [ ! -d $(CISCO_PLATFORM_SRC) ]; then git clone -b $(CISCO_PLATFORM_BRANCH) $(CISCO_PLATFORM_URL) $(CISCO_PLATFORM_SRC); fi)
It is another issue, build break on master, we can re-build code.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#7821 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ASPBHRRCFPE7D3NKLWEU5X3TSA4B3ANCNFSM46KMRCIA>.
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
this is fix fixed and diffs uploaded. |
|
6/15: Code upstreaming meeting notes
|
|
@xumia - can you please help with merge asap, blocking image build. |
@VenkatCisco , I added two comments, it was resolved without any comments. CISCO_PLATFORM_BRANCH := cisco-8000/master Do we need to change to I cannot access https://github.com/Cisco-sonic-8000, only can access https://github.com/Cisco-8000-sonic/platform-cisco-8000 |
|
Closing it to track the fix via #8172 |
Why I did it
Add new platform cisco-8000 directory under sonic-buildimage.
How I did it
create a new directory under platform called "cisco-8000" and introduce rules.mk.
How to verify it
git clone [email protected]:Azure/sonic-buildimage.git
mkdir platform/cisco-8000
make init
make configure PLATFORM=cisco-8000
make all
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)