SONiC Yang model support for LLDP #8120
Conversation
|
Hi @venkatmahalingam , @praveen-li - could you please review and approve. This is dup of #7191 |
| description | ||
| "SONiC LLDP yang model"; | ||
|
|
||
| revision 2020-04-16 { |
There was a problem hiding this comment.
Please update the date.
| "RX/TX mode for LLDP frames"; | ||
| } | ||
|
|
||
| //uses lldp_mode_config; |
There was a problem hiding this comment.
We should use the grouping, Praveen mentioned in the last meeting that only few lines are required in the infra, @praveen-li please provide the infra code for testing.
| } | ||
|
|
||
| leaf supp_mgmt_address_tlv { | ||
| type boolean; |
There was a problem hiding this comment.
no default value for this field?
There was a problem hiding this comment.
Added default value
| type enumeration { | ||
| enum RECEIVE; | ||
| enum TRANSMIT; | ||
| } |
There was a problem hiding this comment.
no default value?
There was a problem hiding this comment.
This is optional field, so user can set the mode to either tx-only or rx-only and 'both tx and rx' is controlled by enabled field
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -924,6 +924,24 @@ | |||
| "trap_ids": "ip2me", | |||
| "trap_group": "queue1_group1" | |||
| } | |||
| }, | |||
| "LLDP": { | |||
There was a problem hiding this comment.
BTW what is the source of this config?, this config is not listed on https://github.com/Azure/SONiC/wiki/Configuration.
There was a problem hiding this comment.
LLDP parameters were directly configured via lldpcli. To support north bound interfaces,these configs were added by Broadcom to configure LLDP global and per port parameters and store the same in Config DB.
| "Initial revision."; | ||
| } | ||
|
|
||
| grouping lldp_mode_config { |
There was a problem hiding this comment.
Any reason by grouping is used?
There was a problem hiding this comment.
Enabled and mode leaf is used in Global and per Port config. So it was grouped and used in these nodes. However usage of grouping is leading to compilation error, its commented for now. But ideally since its used in two places, grouping is defined.
|
Hi @venkatmahalingam , @praveen-li - Do you have there any further comments or questions |
|
@lguohan will merge this one. Thanks. |
What I did
Created SONiC Yang model for LLDP
How I did it
Added LLDP and LLDP_PORT tables for global and port level configurations
How to verify it
Compile sonic_yang_mgmt-1.0-py3-none-any.whl