[202012] Replace swsssdk with swsscommon in sonic-host-services and update submodule sonic-swss-common #8513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sujinmkang
reviewed
Aug 18, 2021
| @@ -1,6 +1,6 @@ | |||
| import os | |||
| import sys | |||
| import swsssdk | |||
| import swsscommon | |||
There was a problem hiding this comment.
just minor cosmetic changes, same as the changes in other files, can you change this to "from swsscomm import swsscommon"? #Resolved
There was a problem hiding this comment.
I submit another PR on master to solve your comments: #8515.
Keep this PR as simple as backport.
| @@ -10,7 +10,7 @@ | |||
| from .mock_configdb import MockConfigDb | |||
|
|
|||
|
|
|||
| swsssdk.ConfigDBConnector = MockConfigDb | |||
| swsscommon.swsscommon.ConfigDBConnector = MockConfigDb | |||
There was a problem hiding this comment.
And also change this line to just "swsscommon.ConfigDBConnector = MockConfigDb"? #Resolved
sujinmkang
approved these changes
Aug 18, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
force-pushed
the
qiluo/hostserv_swsscommon202012
branch
from
4a1df0a to
9ef593c
Compare
qiluo-msft
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Backport #8034 to 202012 branch
sonic-swss-common submodule updating includes below commits
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)