DellEMC: Z9332f - SFP API get_error_description implementation #9071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ArunSaravananBalachandran can you address the build failure |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
requested changes
Nov 2, 2021
| return self.SFP_STATUS_UNPLUGGED | ||
| else: | ||
| if not os.path.isfile(self.eeprom_path): | ||
| return "EEPROM driver is not initialized" |
There was a problem hiding this comment.
should this be optoe driver? i believe if the binding to optoe driver fails then the sysfs eeprom file wont' be created.
There was a problem hiding this comment.
Have updated the error message to "EEPROM driver is not attached"
| elif self.sfp_type == 'QSFP': | ||
| offset = QSFP_INFO_OFFSET | ||
| elif self.sfp_type == 'QSFP_DD': | ||
| offset = QSFP_DD_PAGE0 |
There was a problem hiding this comment.
handle unknown type error i.e if sfp_type is neither SFP, QSFP nor QSFP-DD
There was a problem hiding this comment.
In the current implementation the value of instance variable sfp_type will not have any other value than one of SFP, QSFP, QSFP_DD
prgeor
approved these changes
Nov 4, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To implement SFP API get_error_description for DellEMC Z9332f.
How I did it
Implement the API in sfp.py
How to verify it
Verified that the return type is as expected.
UT logs: Z9332f_UT_logs.txt
Which release branch to backport (provide reason below if selected)
Description for the changelog
DellEMC: Z9332f - SFP API get_error_description implementation
A picture of a cute animal (not mandatory but encouraged)