You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On VS Chassis platform, the sonic_platform package is not implemented since there is no hardware associated with it. So the chassis.get_reboot_cause API will throw NotImplementedError. I added the code change to handle this exception and return the reboot cause as "N/A" in this case.
BYGX-wcr
changed the title
Handle NotImplementedError that will be thrown on VS Chassis platform
Handle NotImplementedError in determine-reboot-cause that will be thrown on VS Chassis platform
Feb 5, 2025
On VS Chassis platform, the sonic_platform package is not implemented since there is no hardware associated with it. So the chassis.get_reboot_cause API will throw NotImplementedError
@BYGX-wcr the sonic_platform package is installed for vs_chassis. the get_reboot_cause api is not implemented there. Did you get chance to check how its working on pizza box kvm image?
On VS Chassis platform, the sonic_platform package is not implemented since there is no hardware associated with it. So the chassis.get_reboot_cause API will throw NotImplementedError
@BYGX-wcr the sonic_platform package is installed for vs_chassis. the get_reboot_cause api is not implemented there. Did you get chance to check how its working on pizza box kvm image?
On T0/T1 KVM devices, the sonic_platform package is not installed at all. So, it won't cause an uncaptured runtime exception.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BYGX-wcr
changed the title
On VS Chassis platform, the sonic_platform package is not implemented since there is no hardware associated with it. So the chassis.get_reboot_cause API will throw NotImplementedError. I added the code change to handle this exception and return the reboot cause as "N/A" in this case.