Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Reverted "ssh_key" to "ssh_string" #216

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

muhammadalihussnain
Copy link
Contributor

Link to all PRs of the KDUMP = KDUMP SONiC HLD PR

Related YANG model : KDUMP YANG MODEL - remote - ssh_string - ssh_path

Issue:

  • There were variables error in the hostcfgd pr, which were not reflecting with the YANG model.
  • To fix, this created a PR - Updated Key and Path. but there was a typo from my end.
  • Now to fix everything, this last PR has been created by to sync YANG model with the hostcfgd. In this PR, I have "ssh_key" with "ssh_string", matching YANG string keys.

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@FengPan-Frank FengPan-Frank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdwhdw hdwhdw merged commit 7e1b280 into sonic-net:master Feb 11, 2025
5 checks passed
muhammadalihussnain added a commit to muhammadalihussnain/sonic-host-services that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants