Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a new ACL table type called L3V4V6. #71

Closed
wants to merge 2 commits into from

Conversation

rck-innovium
Copy link

Support a new ACL table type called L3V4V6.

This table supports both v4 and v6 Match types.

HLD: sonic-net/SONiC#1267

Signed-off-by: Ravi(Marvell) [email protected]

This table supports both v4 and v6 Match types.

HLD: sonic-net/SONiC#1267

Signed-off-by: Ravi(Marvell) [email protected]
@venkatmahalingam
Copy link

@rck-innovium
Copy link
Author

@tomek-US
Copy link

@venkatmahalingam, is my understanding correct that your comment has been resolved?

Copy link

@tomek-US tomek-US left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@venkatmahalingam
Copy link

venkatmahalingam commented May 20, 2023

@venkatmahalingam, is my understanding correct that your comment has been resolved?

I dont think this pull request is required as the changes are already merged using sonic-net/sonic-buildimage#14803

@rck-innovium
Copy link
Author

@venkatmahalingam, is my understanding correct that your comment has been resolved?

I dont think this pull request is required as the changes are already merged using sonic-net/sonic-buildimage#14803

@venkatmahalingam  Thanks for pointing out that the yang models in the sonic-buildimage must be updated.  I want to understand why not keep sonic-mgmt-common in sync with the yang models in the sonic-buildimage?

@venkatmahalingam
Copy link

@venkatmahalingam, is my understanding correct that your comment has been resolved?

I dont think this pull request is required as the changes are already merged using sonic-net/sonic-buildimage#14803

@venkatmahalingam  Thanks for pointing out that the yang models in the sonic-buildimage must be updated.  I want to understand why not keep sonic-mgmt-common in sync with the yang models in the sonic-buildimage?

If you put the SONiC YANG model in sonic-mgmt-common, it will break some of the functionalities (e.g sonic-mgmt-common repo uses list with single entry for a global table whereas sonic-buildimage yang model uses singleton container) supported, we're working to use the sonic-buildimage YANG model for sonic-mgmt-common as well, until then let's not worry about common SONiC YANG models in both the repos.

@rck-innovium
Copy link
Author

If you put the SONiC YANG model in sonic-mgmt-common, it will break some of the functionalities (e.g sonic-mgmt-common repo uses list with single entry for a global table whereas sonic-buildimage yang model uses singleton container) supported, we're working to use the sonic-buildimage YANG model for sonic-mgmt-common as well, until then let's not worry about common SONiC YANG models in both the repos.

@venkatmahalingam Thanks for explaining. I'll close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants