Updating ingress drop counters for 100G_120k profile in qos #10146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
judyjoseph
approved these changes
Oct 2, 2023
vmittal-msft
approved these changes
Oct 2, 2023
|
Cherry-pick PR to 202205: #10389 |
6 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Oct 19, 2023
mssonicbld
added
Included in 202205 branch
and removed
Created PR to 202205 branch
labels
wangxin
added
Approved for 202305 branch
and removed
Approved for 202205 branch
Approved for 202305 branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 2, 2023
|
Cherry-pick PR to 202305: #10576 |
6 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Nov 2, 2023
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
3 tasks
arlakshm
pushed a commit
that referenced
this pull request
Feb 13, 2024
The J2c+ qos params for 100_120K was updated in #10146 but it wasn't updated for J2. This has caused failures on testQosSaiPfcXoffLimit because we aren't sending sufficient packets to fill up the headroom so packets aren't being dropped. I confirmed on a J2 system with these new values we end up filling up the headroom and drop packets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Aligning to the change in PR# sonic-net/sonic-buildimage#16690
Summary:
The ingress drop counter value adjusted in qos_params.j2c to align with change in total headroom pool size (PR#16690 )
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
PCFXoff test cases failure
How did you do it?
How did you verify/test it?
Executed qos test for T2 topology.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation