Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macsec]: Add a sleep at the link flap retry for the flaky failure #12324

Merged

Conversation

Pterosaur
Copy link
Contributor

@Pterosaur Pterosaur commented Apr 7, 2024

Description of PR

Summary:
Fixes # (issue) 27459603

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

There is a flaky failure on the macsec_test_fault_handling. It's due to the lag of DUT exceeding MKA_TIMEOUT that triggers a rekey.

How did you do it?

To mitigate this, retry the test after a while with a few seconds of idle time.

How did you verify/test it?

Check Azp

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

This test may fail due to the lag of DUT exceeding MKA_TIMEOUT that triggers a rekey.
To mitigate this, retry the test after a while with a few seconds of idle time.

Signed-off-by: Ze Gan <[email protected]>
Copy link
Contributor

@xwjiang-ms xwjiang-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pterosaur
Copy link
Contributor Author

@yejianquan Could you please help to merge this PR?

Copy link
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit 99675f5 into sonic-net:master Apr 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants