Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snappi_tests:T2: Serialize the udp ports for all_to_all test #16613

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

rraghav-cisco
Copy link
Contributor

Description of PR

Summary:
The all_to_all test is still using the random udp ports, and runs into random failures. This PR serializes the udp ports for traffic streams.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Random failure in all_to_all multidut snappi tests.

How did you do it?

Serialized the udp port numbers used by this script.

How did you verify/test it?

Ran it on my TB. I verified that I could recreate the issue first, and then after the modifications, it passed:

_____________________________________________________________________ test_multidut_pfcwd_all_to_all[multidut_port_info3-False] ______________________________________________________________________
--------------------------------------------------- generated xml file: /run_logs/ixia/20188-reruns/2025-01-21-09-42-25/tr_2025-01-21-09-42-25.xml ---------------------------------------------------
INFO:root:Can not get Allure report URL. Please check logs
====================================================================================== short test summary info =======================================================================================
PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_a2a_with_snappi.py::test_multidut_pfcwd_all_to_all[multidut_port_info3-False]
============================================================================= 1 passed, 4 warnings in 411.17s (0:06:51) ==============================================================================
sonic@snappi-sonic-mgmt-vanilla-202405-t2:/data/tests$ 

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rraghav-cisco
Copy link
Contributor Author

The global pause is skipped for cisco-8000, @auspham , Can you pls verify for other platforms?

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
--------------------------------------------------- generated xml file: /run_logs/ixia/20188-reruns/2025-01-21-18-35-48/tr_2025-01-21-18-35-48.xml ---------------------------------------------------
INFO:root:Can not get Allure report URL. Please check logs
====================================================================================== short test summary info =======================================================================================
SKIPPED [4] snappi_tests/multidut/pfc/test_multidut_global_pause_with_snappi.py:20: Global pause is not supported in cisco-8000.
=================================================================================== 4 skipped, 1 warning in 12.60s ===================================================================================
sonic@snappi-sonic-mgmt-vanilla-202405-t2:/data/tests$ 

@auspham
Copy link
Contributor

auspham commented Jan 28, 2025

@rraghav-cisco I dont have t2 rdma but i have verified on t0 regression:

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
- generated xml file: /var/src/sonic-mgmt_vms20-rdma-t0-7050cx3_647a2010a94c9fdb979de1d8/tests/logs/snappi_tests/multidut/pfc/test_multidut_global_pause_with_snappi.xml -
================== 2 passed, 5 warnings in 614.94s (0:10:14) ===================

Copy link
Contributor

@sdszhang sdszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#41

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jan 31, 2025
…et#16613)

Description of PR
Summary:
The all_to_all test is still using the random udp ports, and runs into random failures. This PR serializes the udp ports for traffic streams.

Approach
What is the motivation for this PR?
Random failure in all_to_all multidut snappi tests.

How did you do it?
Serialized the udp port numbers used by this script.

How did you verify/test it?
Ran it on my TB. I verified that I could recreate the issue first, and then after the modifications, it passed:

_____________________________________________________________________ test_multidut_pfcwd_all_to_all[multidut_port_info3-False] ______________________________________________________________________
--------------------------------------------------- generated xml file: /run_logs/ixia/20188-reruns/2025-01-21-09-42-25/tr_2025-01-21-09-42-25.xml ---------------------------------------------------
INFO:root:Can not get Allure report URL. Please check logs
====================================================================================== short test summary info =======================================================================================
PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_a2a_with_snappi.py::test_multidut_pfcwd_all_to_all[multidut_port_info3-False]
============================================================================= 1 passed, 4 warnings in 411.17s (0:06:51) ==============================================================================
sonic@snappi-sonic-mgmt-vanilla-202405-t2:/data/tests$ 

co-authorized by: [email protected]
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #16740

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants