-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snappi_tests:T2: Serialize the udp ports for all_to_all test #16613
Merged
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
8 tasks
The global pause is skipped for cisco-8000, @auspham , Can you pls verify for other platforms?
|
@rraghav-cisco I dont have t2 rdma but i have verified on t0 regression:
|
sdszhang
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
11 tasks
Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#41 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 31, 2025
…et#16613) Description of PR Summary: The all_to_all test is still using the random udp ports, and runs into random failures. This PR serializes the udp ports for traffic streams. Approach What is the motivation for this PR? Random failure in all_to_all multidut snappi tests. How did you do it? Serialized the udp port numbers used by this script. How did you verify/test it? Ran it on my TB. I verified that I could recreate the issue first, and then after the modifications, it passed: _____________________________________________________________________ test_multidut_pfcwd_all_to_all[multidut_port_info3-False] ______________________________________________________________________ --------------------------------------------------- generated xml file: /run_logs/ixia/20188-reruns/2025-01-21-09-42-25/tr_2025-01-21-09-42-25.xml --------------------------------------------------- INFO:root:Can not get Allure report URL. Please check logs ====================================================================================== short test summary info ======================================================================================= PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_a2a_with_snappi.py::test_multidut_pfcwd_all_to_all[multidut_port_info3-False] ============================================================================= 1 passed, 4 warnings in 411.17s (0:06:51) ============================================================================== sonic@snappi-sonic-mgmt-vanilla-202405-t2:/data/tests$ co-authorized by: [email protected]
Cherry-pick PR to 202411: #16740 |
11 tasks
sdszhang
added
Included in msft-202405 Branch
and removed
Created PR to msft-202405 Branch
labels
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
The all_to_all test is still using the random udp ports, and runs into random failures. This PR serializes the udp ports for traffic streams.
Type of change
Back port request
Approach
What is the motivation for this PR?
Random failure in all_to_all multidut snappi tests.
How did you do it?
Serialized the udp port numbers used by this script.
How did you verify/test it?
Ran it on my TB. I verified that I could recreate the issue first, and then after the modifications, it passed: