Fix the conditional check for FEC errors #16700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
reviewed
Jan 28, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
approved these changes
Jan 29, 2025
|
If we do this change, does that mean passed test now will fail, and failed test now will pass? |
|
Discussed offline, better to check if FEC counter is 0. The comparison can be skipped if FEC counter is 0. |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 29, 2025
* Fix the conditional check for FEC errors * Fix the comment
|
Cherry-pick PR to 202405: #16715 |
11 tasks
@bingwang-ms No, test cases which are failing are the ones with non-zero's. So this will not be true. |
@bingwang-ms I have opened #16722 PR to address this additional check. Thank you! |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 30, 2025
* Fix the conditional check for FEC errors * Fix the comment
|
Cherry-pick PR to 202411: #16724 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jan 30, 2025
* Fix the conditional check for FEC errors * Fix the comment
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Jan 31, 2025
* Fix the conditional check for FEC errors * Fix the comment
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
FEC correctable codeword errors should not exceed FEC symbol errors, as a codeword is composed of multiple symbols. If this occurs, it likely indicates a reporting bug, misconfiguration, or data misinterpretation, requiring validation of counters, FEC settings, and system behavior. Fix the conditional check in the test case accordingly.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Issue in the conditional check
How did you do it?
Fix the conditional check for FEC errors
How did you verify/test it?
Verified on SN4700 platform.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation