[ACL] Fix ACL rules are not ready yet when test cases are started in as5835_54t model #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
write to hardware chip already.
|
/Azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
daall
reviewed
Feb 22, 2021
tests/acl/test_acl.py
Outdated
| def check_rule_counters(self, duthost): | ||
| logger.info('Wait all rule counters are ready') | ||
|
|
||
| return wait_until(300, 2, self.check_rule_counters_internal, duthost) |
There was a problem hiding this comment.
300 seems a bit long, could we set this to something like 30 or 60?
There was a problem hiding this comment.
Updated code to wait for ACL rule counters ready in 60 seconds. Thanks.
|
@shihhsien-wang Can you address the review comments? Then we can proceed with merging this PR. |
Just updated code for the review comment. Sorry for late reply. |
wangxin
approved these changes
Apr 1, 2021
nirmalya-keysight
pushed a commit
to nirmalya-keysight/sonic-mgmt
that referenced
this pull request
Apr 5, 2021
…as5835_54t model (sonic-net#2961) What is the motivation for this PR? Fix failed test cases in as5835_54t model. How did you do it? Check output of aclshow -a command and ensure that one or more rules are able to displayed and values of counters are not N/A. How did you verify/test it? Run the modified code in as5835_54t model to ensure that the problem is fixed.
wangxin
pushed a commit
that referenced
this pull request
Apr 13, 2021
Why I did: Changes done as part of #2961 broke the multi-asic platforms. How I did: Made changes done as part of #2961 multi-asic compatible. How I verify: Verified for both multi-asic and single asic platforms. Signed-off-by: Abhishek Dosi <[email protected]>
saravanansv
pushed a commit
to saravanansv/sonic-mgmt
that referenced
this pull request
May 6, 2021
…as5835_54t model (sonic-net#2961) What is the motivation for this PR? Fix failed test cases in as5835_54t model. How did you do it? Check output of aclshow -a command and ensure that one or more rules are able to displayed and values of counters are not N/A. How did you verify/test it? Run the modified code in as5835_54t model to ensure that the problem is fixed.
saravanansv
pushed a commit
to saravanansv/sonic-mgmt
that referenced
this pull request
May 6, 2021
Why I did: Changes done as part of sonic-net#2961 broke the multi-asic platforms. How I did: Made changes done as part of sonic-net#2961 multi-asic compatible. How I verify: Verified for both multi-asic and single asic platforms. Signed-off-by: Abhishek Dosi <[email protected]>
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
…as5835_54t model (sonic-net#2961) What is the motivation for this PR? Fix failed test cases in as5835_54t model. How did you do it? Check output of aclshow -a command and ensure that one or more rules are able to displayed and values of counters are not N/A. How did you verify/test it? Run the modified code in as5835_54t model to ensure that the problem is fixed.
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
Why I did: Changes done as part of sonic-net#2961 broke the multi-asic platforms. How I did: Made changes done as part of sonic-net#2961 multi-asic compatible. How I verify: Verified for both multi-asic and single asic platforms. Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Add check code to ensure ACL rules are already written to hardware chip by check and wait until the output of
aclshow -acommand is OK.Summary:
Fixes the failed test cases in
as5835_54tmodel (or other models equipped with Broadcom chip), because of the rules are not set to Broadcom chip yet but the test case is already started to test. In this case, the first few test cases whose patterns liketest_unmatched_blockedandtest_XXX_droppedsometimes fail.Type of change
Approach
What is the motivation for this PR?
Fix failed test cases in
as5835_54tmodel.How did you do it?
Check output of
aclshow -acommand and ensure that one or more rules are able to displayed and values of counters are notN/A.How did you verify/test it?
Run the modified code in
as5835_54tmodel to ensure that the problem is fixed.Any platform specific information?
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A