Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fabric test plan #5678

Merged
merged 7 commits into from
Nov 22, 2023

Conversation

jfeng-arista
Copy link
Contributor

@jfeng-arista jfeng-arista commented May 18, 2022

Description of PR

Summary: Update fabric test plan
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@ghost
Copy link

ghost commented May 18, 2022

CLA assistant check
All CLA requirements met.

@kenneth-arista
Copy link
Contributor

@arlakshm for awareness

@kenneth-arista
Copy link
Contributor

/Azp run Azure.sonic-mgmt

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 5678 in repo Azure/sonic-mgmt

@jfeng-arista
Copy link
Contributor Author

/Azp run Azure.sonic-mgmt

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 5678 in repo Azure/sonic-mgmt


The above diagram illustrates an example system under test. Every forwarding ASIC is connected to every fabric ASIC.

The expected fabric link status is stored in the last section of testbed.yaml file, which is called fabric_link_toplogy. The expected status is provided per host and per ASIC, and the format is as follows:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please specify if this check is expected to be done on all line cards and sup as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check is done for both linecards and fabric cards on sup. I also updated document with this information

@rlhui
Copy link

rlhui commented Jun 8, 2022

As this is to model the fabric links with software/defined in yaml file, is this applicable for packet based chassis too?

peer_status: <connected/not_connected>
```

Initially, testbed.yaml will contain fabric link status, such as whether or not links are connected. In the future, this information may be extended to contain fabric link connection information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if this information can be added in the seperate yaml file for each testbed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The the fabric link map information is generated dynamically when run the test based on which slot the card is inserted in the system , which type of cards ( sku ), and all these information is in the testbed.yaml file now, and we can get the information while generating the testbed.yaml file and the same time update the fabric topology into it. If they are in separate files, then we will need to get the information from processing the testbed.yaml and then generate the fabric topology into a different files, this can be done , but it will taking longer time also need to parse the same information several times . So we want to double check here if we still want to have the fabric topology information in a separate yaml file ? thank you !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with Arvind, the information will be added in separate yaml files for each type of cards.

@jfeng-arista
Copy link
Contributor Author

/easycla

arlakshm
arlakshm previously approved these changes Jun 16, 2023
@arlakshm
Copy link
Contributor

Hi @jfeng-arista, please fix the conflicts

@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing docs/testplan/Chassis-fabric-test-plan.md

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.....................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@jfeng-arista
Copy link
Contributor Author

/easycla

@arlakshm arlakshm merged commit 1a1800a into sonic-net:master Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants