Extend IP-in-IP test to check IPv6 in IPv4, IPv4 in IPv6, IPv6 in IP… #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v6 decapsulation Signed-off-by: stepanb <[email protected]>
sihuihan88
reviewed
Aug 20, 2018
|
|
||
| always: | ||
| # Delete the configuration | ||
| - set_fact: op="DEL" |
There was a problem hiding this comment.
What is the default op value? If setting op="DEL" in the cleanup, will it has side-effect in case there are following tests?
There was a problem hiding this comment.
it is set to 'SET' on line 78. It should not have any side effects, it is used to cleanup the configured tunnels
There was a problem hiding this comment.
What will happen if the other tests run afterwards? Will the op="DEL" for all the up coming tests? Is it possible that it will clean up configurations needed for other tests?
There was a problem hiding this comment.
Prefer to set op=“DEL” as a local value for the command, eg using with_item
Signed-off-by: Stepan Blyschak <[email protected]>
sihuihan88
approved these changes
Aug 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…v6 decapsulation
Signed-off-by: stepanb [email protected]
Description of PR
Summary:
Extend IP-in-IP decapsulation test to pass different combinations of tunneled traffic (IPv6 in IPv4, IPv4 in IPv6, IPv6 in IP…)
Type of change
Approach
How did you do it?
Extend PTF test
How did you verify/test it?
Run the test
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation