Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testcase for bgp container in container hardening #8694

Merged
merged 7 commits into from
Jul 21, 2023
Merged

testcase for bgp container in container hardening #8694

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
68b048c
test container hardening
maipbui Jun 22, 2023
faf467f
address comments
maipbui Jun 23, 2023
cdf6957
add test to python3 test files
maipbui Jun 23, 2023
8cf6217
address comments
maipbui Jun 28, 2023
28f3c99
Merge branch 'master' into bgp_dev
maipbui Jul 5, 2023
5ba3fa6
make test generic
maipbui Jul 5, 2023
fd940fa
address comments
maipbui Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions tests/container_hardening/test_container_hardening.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import pytest
import logging
from tests.common.helpers.assertions import pytest_assert

pytestmark = [
pytest.mark.topology('any'),
pytest.mark.device_type('vs')
]

logger = logging.getLogger(__name__)


def test_bgp_dev(duthost):
"""
Test bgp container has no access to /dev/vda*
"""
output = duthost.shell("docker exec bgp bash -c 'ls /dev | grep vda'", module_ignore_errors=True)['stdout']
Copy link
Contributor

@qiluo-msft qiluo-msft Jun 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is vda and why grep it? #Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/dev/vda in vs image is similar to /dev/sda

admin@vlab-03:~$ docker exec -it bgp bash -c 'ls /dev | grep vda'
admin@vlab-03:~$ docker exec -it telemetry bash -c 'ls /dev | grep vda'
vda
vda1
vda2
vda3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only working in KVM environments. In most DUT, you want to check /dev/sdaN.
You may find a flexible way to check the main disk device.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified to a more general way to check the device, thanks!

pytest_assert(not output, 'vda is not removed from /dev')