-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dual-tor dhcpv6 relay test cases failure in latest image #9842
Conversation
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
4284792
to
8db29e7
Compare
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
8db29e7
to
851c45b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cherry-pick PR to 202305: #9941 |
@jcaiMR PR conflicts with 202205 branch |
What is the motivation for this PR? Cherry pick (#9842) to 202205 Code gap is big, solution refined based on 202205 base code. How did you do it? How did you verify/test it? dhcp_relay/test_dhcpv6_relay.py::test_dhcp_relay_default dhcp_relay/test_dhcpv6_relay.py::test_dhcpv6_relay_counter
Description of PR
Fix test_dhcpv6_relay.py case test_dhcp_relay_default and test_dhcpv6_relay_counter failure on dualtor.
The issue is test gap after code commit of sonic-net/sonic-dhcp-relay#42 in master
and sonic-net/sonic-dhcp-relay#40 in 202012.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix test_dhcpv6_relay.py case test_dhcp_relay_default and test_dhcpv6_relay_counter failure on dualtor.
So test case need modify to send Relay-Reply to loopback0 ipv6 address.
Note for future code change:
How did you do it?
run dhcp_relay/test_dhcpv6_relay.py
How did you verify/test it?
Test case pass on dual tor and single tor
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation