-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Smartswitch] Fix time format for dpu states #583
Conversation
/azp run |
Pull request is closed |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@rameshraghupathy @vvolam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gpunathilell Looks good to me.
Can we have a test case where we can check the time format for all states is same UTC?
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@vvolam Added tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Currently the time format being updated by the DPU and Switch are not aligned, this PR takes the common format from the HLD for all 3 states - midplane state, controlplane state and dataplane state
This also fixes the issue where the local time was represented incorrectly as UTC time
Motivation and Context
Current format:
After fix:
How Has This Been Tested?
Additional Information (Optional)