Fix for dpu midplane state update affecting dpu control_plane/data_plane state :issue-21371 #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rameshraghupathy
force-pushed
the
issue-21371
branch
from
bd6da09 to
0e86f8e
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
gpunathilell
approved these changes
Jan 28, 2025
|
/azp run |
|
Commenter does not have sufficient privileges for PR 584 in repo sonic-net/sonic-platform-daemons |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for dpu midplane state update affecting dpu control_plane/data_plane state
Description
The dpu midplane update and the dpu cp/dp state update happen in parallel. The midplane state update function reads the data from redis-DB, udpates the midplane state and then writes back the entire table. It appears like the DPU cp/dp state update sometimes goes in between the midplane read and and write causing a wrong update of dpu cp/dp states. The fix is to avoid reading the table and just write only the dpu midplane state. This will solve the problem.
Fixes: sonic-net/sonic-buildimage#21371
Motivation and Context
The dpu midplane update and the dpu cp/dp state update happen in parallel. The midplane state update function reads the data from redis-DB, udpates the midplane state and then writes back the entire table. It appears like the DPU cp/dp state update sometimes goes in between the midplane read and and write causing a wrong update of dpu cp/dp states. The fix is to avoid reading the table and just write only the dpu midplane state. This will solve the problem.
How Has This Been Tested?
Toggle the DPU on/off state multiple times and see if the state is reflected properly. Since, this code path is nvidia specific relying on their testing as well.
Additional Information (Optional)