[configdb]: add mod_entry, rename set_config to mod_config #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mod_entry will not delete extra data in the db. change the set_config to mod_config so that mod_config does not delete extra data in the db
taoyl-ms
reviewed
Dec 7, 2017
src/swsssdk/configdb.py
Outdated
| def set_config(self, data): | ||
| """Write multiple tables into config db. | ||
| def mod_config(self, data): | ||
| """Write multiple tables into config db. Existing entries in the db are kept. |
There was a problem hiding this comment.
It's not "Existing entries are kept" (if existing entry occurs in data it will be modified), but "Untouched entries and untouched attributes of existing entries are kept".
There was a problem hiding this comment.
how about "extra entries/attributes in the db are kept"?
taoyl-ms
approved these changes
Dec 7, 2017
praveen-li
pushed a commit
to praveen-li/sonic-py-swsssdk
that referenced
this pull request
May 4, 2021
* msft_github/master: [configdb]: Addopt get_table method to work with python3. (sonic-net#26) [configdb]: add mod_entry, rename set_config to mod_config (sonic-net#25) [configdb] fix bug of leaving unwanted columns in a hash (sonic-net#23) Revert "Add support to remove the key of table entry (sonic-net#15)" (sonic-net#24) Add support to remove the key of table entry (sonic-net#15) [configdb] support redis connecting methods other than TCP (sonic-net#22) [interface]: Extend the max data wait time to 60s (sonic-net#21)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mod_entry will not delete extra data in the db.
change the set_config to mod_config so that mod_config does not
delete extra data in the db