-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Voqs to Virtual Switch #1061
Conversation
vslib/SwitchStateBase.h
Outdated
@@ -108,6 +108,8 @@ namespace saivs | |||
_In_ uint32_t sys_port_count, | |||
_In_ const sai_system_port_config_t *sys_port_cfg_list); | |||
|
|||
sai_status_t create_voqs(); | |||
sai_status_t create_voq_per_sysport(_In_ sai_object_id_t sys_port_id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move paremater to second line like in other functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the parameter. The coverage seems to be not detecting the coverage added my new test. I checked in my local environment, the new functions are exercised by the test I added. @kcudnik
please satisfy code coverage |
not sure about that, i believe i had the same issue that tests added in perl script was not counting coverage, maybe they generate gcov files in different location or something like that, and it's not picked up by code coverage engine, i don't have root cause here :( |
/Azp run Azure.sonic-sairedis |
Azure Pipelines successfully started running 1 pipeline(s). |
Update sonic-sairedis submodule pointer to include the following: * af80caa Add Voqs to Virtual Switch ([sonic-net#1061](sonic-net/sonic-sairedis#1061)) * f9008ad [fastboot] fastboot enhancement: Use warm-boot infrastructure for fast-boot ([sonic-net#1100](sonic-net/sonic-sairedis#1100)) Signed-off-by: dprital <[email protected]>
* Add Voqs to Virtual Switch * Add UnitTest.
@skbarista this change cannot be cherry-picked cleanly to 202205. Can you enter new PR for 202205 branch? |
* Add Voqs to Virtual Switch * Add UnitTest.
* Add Voqs to Virtual Switch * Add UnitTest.
#1162 is the 202205 PR. |
Add Voqs to Virtual Switch. This is needed for virtual chassis tests to pass it sonic-net/sonic-swss#1913