[MultiDB]: repalce old APIs with New APIs incuding testing #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qiluo-msft FYI, since this changes are using sonic-db-cli, we need to update sonic-py-swsssdk to sonic-net/sonic-py-swsssdk#54 at least. Otherwise, sonic-db-cli is not there. [This part already DONE] |
qiluo-msft
reviewed
Nov 22, 2019
|
Please submit a submodule update PR, and block on it. In reply to: 557719524 [](ancestors = 557719524) |
dzhangalibaba
force-pushed
the
multidb_replace
branch
from
40bcd9e to
5ecf2c4
Compare
|
@qiluo-msft @kcudnik Now it depends on sonic-net/sonic-buildimage#3863, we need the latest libswsscommon to apply the new APIs at sairedis, otherwise sairedis testing will fail. BLOCK this until libswsscommon submodule is updated. |
|
Retest this please |
qiluo-msft
approved these changes
Dec 10, 2019
Thanks Qi. @kcudnik could you take a look and see if any concern in sairedis ? |
kcudnik
approved these changes
Dec 11, 2019
|
good to go |
abdosi
added
the
Request for 201911 Branch
abdosi
pushed a commit
that referenced
this pull request
Jan 3, 2020
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
jianyuewu
pushed a commit
to jianyuewu/sonic-sairedis
that referenced
this pull request
Feb 7, 2025
Signed-off-by: Shu0T1an ChenG <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dong Zhang [email protected]