[meta] Enable strict cast-align warning #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required on ARM architecture where strict alignment is required. Also fixes cast to std::size_t which size is 4 bytes Signed-off-by: kcudnik <[email protected]>
jleveque
approved these changes
Dec 11, 2020
qiluo-msft
reviewed
Dec 11, 2020
| const uint32_t* ip6 = (const uint32_t*)re.destination.addr.ip6; | ||
| // cast is not good enough for arm (cast align) | ||
| uint32_t ip6[4]; | ||
| memcpy(ip6, re.destination.addr.ip6, sizeof(ip6)); |
There was a problem hiding this comment.
addr [](start = 35, length = 4)
I see sai_ip_addr_t is already 4 bytes aligned because ip4 is uint32_t. So the memcpy is preventable.
There was a problem hiding this comment.
somehow on arm architecture it still gives this warning, also i checked assembly on O2, and memcpy is optimized, and it's not there, just direct ip access
kktheballer
pushed a commit
to kktheballer/sonic-sairedis
that referenced
this pull request
Mar 10, 2021
Required on ARM architecture where strict alignment is required. Also fixes cast to std::size_t which size is 4 bytes Signed-off-by: kcudnik <[email protected]>
Merged
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
Required on ARM architecture where strict alignment is required. Also fixes cast to std::size_t which size is 4 bytes Signed-off-by: kcudnik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required on ARM architecture where strict alignment is required.
Also fixes cast to std::size_t which size is 4 bytes
Signed-off-by: kcudnik [email protected]