[vs] Skip MACsec clean up if /sbin/ip is not accessible #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Pterosaur This is just temporary solution here to make things going on sonic buildimage, since you designed this, it would be best if you will handle proper fix for that. |
3 tasks
|
retest this please |
lguohan
approved these changes
Dec 16, 2020
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
kktheballer
pushed a commit
to kktheballer/sonic-sairedis
that referenced
this pull request
Mar 10, 2021
Some build containers for sonic-buildimage may not have ip command, and for non MACsec test's this is not required to be present.
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
Some build containers for sonic-buildimage may not have ip command, and for non MACsec test's this is not required to be present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some build containers for sonic-buildimage may not have ip command, and for non MACsec test's this is not required to be present.