Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fdb flush lua script v2 with switch id support #329

Merged
merged 2 commits into from
Mar 12, 2020

Conversation

kcudnik
Copy link
Contributor

@kcudnik kcudnik commented Feb 15, 2020

No description provided.

@kcudnik kcudnik requested review from qiluo-msft and lguohan March 12, 2020 15:46
@lguohan
Copy link
Contributor

lguohan commented Mar 12, 2020

can you describe the motivation if this change? why we do not need it before?

@kcudnik
Copy link
Contributor Author

kcudnik commented Mar 12, 2020

if you flush fdb on one switch when multiple switches are present in syncd currently it will flush fdb entries from all switches, this change will add support per switch, then previous version can be removed

@lguohan lguohan merged commit 8b54767 into sonic-net:master Mar 12, 2020
@@ -27,6 +27,7 @@ tests_SOURCES = redis_ut.cpp \
selectable_priority.cpp \
warm_restart_ut.cpp \
redis_multi_db_ut.cpp \
fdb_flush.cpp \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  		 [](start = 0, length = 4)

tab->spaces

// "SAI_OBJECT_TYPE_FDB_ENTRY:{\"bvid\":\"oid:0x26000000000545\",\"mac\":\"4A:A8:7B:A2:37:1A\",\"switch_id\":\"oid:0x21000000000000\"}"
// "SAI_FDB_ENTRY_ATTR_TYPE" "SAI_FDB_ENTRY_TYPE_DYNAMIC"
// "SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID" "oid:0x3a000000000567"
// "SAI_FDB_ENTRY_ATTR_PACKET_ACTION" "SAI_PACKET_ACTION_FORWARD"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove dead code

//insert(0x21000000000000, 0x26000000000001, 0x3a000000000001, 1, true);
//insert(0x21000000000000, 0x26000000000002, 0x3a000000000002, 2, false);
//insert(0x121000000000001, 0x126000000000003, 0x13a000000000003, 3, true);
//insert(0x121000000000001, 0x126000000000004, 0x13a000000000004, 4, false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove dead code

@kcudnik kcudnik deleted the fdblua2 branch March 13, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants