-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sonic-slave docker image environment issue. #728
Merged
liushilongbuaa
merged 2 commits into
sonic-net:202205
from
liushilongbuaa:202205-fix-tag
Dec 28, 2022
Merged
Fix sonic-slave docker image environment issue. #728
liushilongbuaa
merged 2 commits into
sonic-net:202205
from
liushilongbuaa:202205-fix-tag
Dec 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azpw run Azure.sonic-swss-common |
/AzurePipelines run Azure.sonic-swss-common |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run Azure.sonic-swss-common |
/AzurePipelines run Azure.sonic-swss-common |
Azure Pipelines successfully started running 1 pipeline(s). |
* Switch to using stock gcovr 5.2 The custom branch we were using previously has since been deleted. That branch appears to have some fix for searching for the source file (for a gcda file) recursively. I don't know if it's needed or not today, but using the stock gcovr 5.2 (from the official repo) appears to work. Signed-off-by: Saikrishna Arcot <[email protected]>
9273f9c
to
2090ae0
Compare
liat-grozovik
previously approved these changes
Dec 27, 2022
2090ae0
to
18e5fd3
Compare
bingwang-ms
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use correct sonic-slave docker image as environment.
Fix build issue.