[zmq] add proxy mode to the ZmqServer #948
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Yakiv-Huryk
commented
Nov 6, 2024
Yakiv-Huryk
commented
- ZmqServer can now work as a proxy server (using ZmqClient to send unprocessed messages)
- add sendRaw() method to the ZmqClient to avoid unnecessary serialization
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Yakiv-Huryk
force-pushed
the
zmq-server-proxy
branch
from
e29b746 to
f4dedbb
Compare
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
oleksandrivantsiv
approved these changes
Nov 19, 2024
* ZmqServer can now work as a proxy server (using ZmqClient to send unprocessed messages) * add sendRaw() method to the ZmqClient to avoid unnecessary serialization
Yakiv-Huryk
force-pushed
the
zmq-server-proxy
branch
from
1d68ab9 to
8b63a41
Compare
liuh-80
reviewed
Dec 4, 2024
| @@ -33,11 +34,23 @@ ZmqServer::~ZmqServer() | |||
| m_mqPollThread->join(); | |||
| } | |||
|
|
|||
| void ZmqServer::enableProxyMode(const std::string& proxy_endpoint) | |||
There was a problem hiding this comment.
When mgmt VRF enabled, do we need VRF parameter here?
|
|
||
| std::unique_ptr<ZmqClient> m_proxy_client; | ||
|
|
||
| std::mutex m_handlerMapMutext; |
There was a problem hiding this comment.
Is this mutex for m_HandlerMap synchronize bug fixing? seems not essential for this proxy mode change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.