[aclorch] Add support for creating ingress and egress MIRROR tables concurrently #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oncurrently Signed-off-by: Danny Allen <[email protected]>
|
retest this please |
|
This pull request introduces 1 alert when merging 2875d8c into e1a5e9a - view on LGTM.com new alerts:
|
|
retest this please |
|
lgtm |
abdosi
reviewed
May 12, 2020
abdosi
reviewed
May 12, 2020
prsunny
approved these changes
May 12, 2020
abdosi
approved these changes
May 27, 2020
abdosi
pushed a commit
that referenced
this pull request
May 28, 2020
…oncurrently (#1286) Signed-off-by: Danny Allen <[email protected]>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen [email protected]
What I did
I made it so that users can create MIRROR tables with ingress ACLs and MIRROR tables with egress ACLs at the same time (and similarly for MIRRORv6 tables).
Why I did it
Currently only one mirror table of each type is allowed in order to support the logic for reconciling combined v4/v6 mirror tables. However, we can differentiate based on ACL stage, keeping the reconciliation logic intact while allowing users to mirror with ingress and egress ACLs simultaneously (on devices that support this).
How I verified it
WIP. I've provided a new VS test case to check the behavior, I'm in the process of testing the changes on a DUT just to be safe.
Details if related