[mock tests] Update MockDBConnector to match new swsscommon interface #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Allen <[email protected]>
lguohan
approved these changes
Oct 12, 2020
|
@qiluo-msft , the function does not seem like a mock. why do we need it? |
|
It is a mock. Without it, a Redis service is required to run gtest unit tests. |
anish-n
pushed a commit
to anish-n/sonic-swss
that referenced
this pull request
Feb 26, 2021
…sonic-net#1465) Signed-off-by: Danny Allen <[email protected]>
kktheballer
pushed a commit
to kktheballer/sonic-swss
that referenced
this pull request
Jul 21, 2021
…sonic-net#1465) Signed-off-by: Danny Allen <[email protected]>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…-net#1465) Use the fast-reboot-dump and filter_fdb_entries scripts to cache the current ARP and FDB tables in /host/config-reload. Also create a file in the same directory to indicate to SWSS that it should restore from the cache. Signed-off-by: Lawrence Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen [email protected]
What I did
I updated the MockDBConnector class to respect the access-level of the m_conn member variable.
Why I did it
sonic-net/sonic-swss-common#387 refactored the DBConnector class and changed the access level of a few member fields. So, to make the mock implementation correct, we need to use the proper setter method to update the redis connection.
How I verified it
Built locally w/ latest sairedis and swsscommon changes.
Details if related
This should fix the following jenkins issue:
https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/sonic-sairedis-build/1344/console
Which will in turn fix this issue:
https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/sonic-swss-build/1944/console